fix: remove python 3.5 travis which following python Markdown, some flake8, Object of type QuerySet is not JSON serializable

Author: agusmakmun

.travis.yml

@@ -3,21 +3,6 @@ sudo: false
 
 matrix:
   include:
-    - python: 3.5
-      env: DJANGO="==1.8.*"
-    - python: 3.5
-      env: DJANGO="==1.9.*"
-    - python: 3.5
-      env: DJANGO="==1.10.*"
-    - python: 3.5
-      env: DJANGO="==1.11.*"
-    - python: 3.5
-      env: DJANGO="==2.0.*"
-    - python: 3.5
-      env: DJANGO="==2.1.*"
-    - python: 3.5
-      env: DJANGO="==2.2.*"
-
     - python: 3.6
       env: DJANGO="==1.8.*"
     - python: 3.6
@@ -59,6 +44,17 @@ matrix:
     - python: 3.8
       env: DJANGO="==3.1.*"
 
+    - python: 3.9
+      env: DJANGO="==2.0.*"
+    - python: 3.9
+      env: DJANGO="==2.1.*"
+    - python: 3.9
+      env: DJANGO="==2.2.*"
+    - python: 3.9
+      env: DJANGO="==3.0.*"
+    - python: 3.9
+      env: DJANGO="==3.1.*"
+
     - os: osx
       language: generic
       env: DJANGO="==3.1.*"

martor/extensions/emoji.py

@@ -9,10 +9,13 @@
 >>> import markdown
 >>> md = markdown.Markdown(extensions=['martor.utils.extensions.mention'])
 >>> md.convert('@[summonagus]')
-'<p><a class="direct-mention-link" href="https://webname.com/profile/summonagus/">summonagus</a></p>'
+'<p><a class="direct-mention-link"
+href="https://example.com/profile/summonagus/">summonagus</a></p>'
 >>>
 >>> md.convert('hello @[summonagus], i mentioned you!')
-'<p>hello <a class="direct-mention-link" href="https://webname.com/profile/summonagus/">summonagus</a>, i mentioned you!</p>'
+'<p>hello <a class="direct-mention-link"
+href="https://example.com/profile/summonagus/">summonagus</a>,
+i mentioned you!</p>'
 >>>
 """
 

martor/extensions/mention.py

@@ -10,13 +10,13 @@
 # Input: string boolean, `true/false`
 MARTOR_ENABLE_CONFIGS = getattr(
     settings, 'MARTOR_ENABLE_CONFIGS', {
-        'emoji': 'true',        # to enable/disable emoji icons.
-        'imgur': 'true',        # to enable/disable imgur/custom uploader.
-        'mention': 'false',     # to enable/disable mention
-        'jquery': 'true',       # to include/revoke jquery (require for admin default django)
-        'living': 'false',      # to enable/disable live updates in preview
-        'spellcheck': 'false',  # to enable/disable spellcheck in form textareas
-        'hljs': 'true',         # to enable/disable hljs highlighting in preview
+        'emoji': 'true',  # enable/disable emoji icons.
+        'imgur': 'true',  # enable/disable imgur/custom uploader.
+        'mention': 'false',  # enable/disable mention
+        'jquery': 'true',  # include/revoke jquery (require for admin django)
+        'living': 'false',  # enable/disable live updates in preview
+        'spellcheck': 'false',  # enable/disable spellcheck in form textareas
+        'hljs': 'true',  # enable/disable hljs highlighting in preview
     }
 )
 
@@ -61,10 +61,10 @@
 
         # Custom markdown extensions.
         'martor.extensions.urlize',
-        'martor.extensions.del_ins',      # ~~strikethrough~~ and ++underscores++
-        'martor.extensions.mention',      # to parse markdown mention
-        'martor.extensions.emoji',        # to parse markdown emoji
-        'martor.extensions.mdx_video',    # to parse embed/iframe video
+        'martor.extensions.del_ins',  # ~~strikethrough~~ and ++underscores++
+        'martor.extensions.mention',  # to parse markdown mention
+        'martor.extensions.emoji',  # to parse markdown emoji
+        'martor.extensions.mdx_video',  # to parse embed/iframe video
         'martor.extensions.escape_html',  # to handle the XSS vulnerabilities
     ]
 )
@@ -76,19 +76,23 @@
 
 # Markdown urls
 MARTOR_UPLOAD_URL = getattr(
-    settings, 'MARTOR_UPLOAD_URL', '/martor/uploader/'  # for imgur
+    settings, 'MARTOR_UPLOAD_URL',
+    '/martor/uploader/'  # for imgur
 )
 MARTOR_SEARCH_USERS_URL = getattr(
-    settings, 'MARTOR_SEARCH_USERS_URL', '/martor/search-user/'  # for mention
+    settings, 'MARTOR_SEARCH_USERS_URL',
+    '/martor/search-user/'  # for mention
 )
 
 # Markdown Extensions
 MARTOR_MARKDOWN_BASE_EMOJI_URL = getattr(
-    settings, 'MARTOR_MARKDOWN_BASE_EMOJI_URL', 'https://github.githubassets.com/images/icons/emoji/'
+    settings, 'MARTOR_MARKDOWN_BASE_EMOJI_URL',
+    'https://github.githubassets.com/images/icons/emoji/'
 )
 
 MARTOR_MARKDOWN_BASE_MENTION_URL = getattr(
-    settings, 'MARTOR_MARKDOWN_BASE_MENTION_URL', 'https://python.web.id/author/'
+    settings, 'MARTOR_MARKDOWN_BASE_MENTION_URL',
+    'https://python.web.id/author/'
 )
 
 # If you need to use your own themed "bootstrap" or "semantic ui" dependency

martor/settings.py

@@ -1,5 +1,5 @@
-
 from django.test import TestCase
+from martor.utils import markdownify, VersionNotCompatible
 
 
 class SimpleTest(TestCase):
@@ -9,12 +9,11 @@ def test_me(self):
         self.assertEqual(response.status_code, 200)
 
     def test_markdownify_error(self,):
-        from martor.utils import markdownify, VersionNotCompatible
-        ## This tests that real errors don't raise VersionNotCompatible
+        # This tests that real errors don't raise VersionNotCompatible
         #  errors, which could be misleading.
         try:
             markdownify(None)
         except Exception as e:
-            self.assertNotIsInstance(e,VersionNotCompatible)
+            self.assertNotIsInstance(e, VersionNotCompatible)
         else:
             self.fail("no assertion raised")

martor/tests/tests.py

@@ -36,15 +36,17 @@ def markdownify(markdown_content):
     except TypeError as e:
         if 'extendMarkdown' not in str(e):
             raise
-        raise VersionNotCompatible("The markdown isn't compatible, please reinstall "
-                                   "your python markdown into Markdown>=3.0")
+        raise VersionNotCompatible(
+            "The markdown isn't compatible, please reinstall "
+            "your python markdown into Markdown>=3.0"
+        )
 
 
 class LazyEncoder(DjangoJSONEncoder):
     """
     This problem because we found error encoding,
-    as docs says, django has special `DjangoJSONEncoder`
-    at https://docs.djangoproject.com/en/1.10/topics/serialization/#serialization-formats-json
+    as docs says, django has special `DjangoJSONEncoder` at
+    https://docs.djangoproject.com/en/dev/topics/serialization/#serialization-formats-json
     also discused in this answer: http://stackoverflow.com/a/31746279/6396981
 
     Usage:

martor/utils.py

@@ -1,6 +1,8 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
+import json
+
 from django.http import (HttpResponse, JsonResponse)
 from django.utils.module_loading import import_string
 from django.utils.translation import ugettext_lazy as _
@@ -9,6 +11,7 @@
 
 from .api import imgur_uploader
 from .settings import MARTOR_MARKDOWNIFY_FUNCTION
+from .utils import LazyEncoder
 
 User = get_user_model()
 
@@ -67,8 +70,9 @@ def markdown_search_user(request):
         queries = {'%s__icontains' % User.USERNAME_FIELD: username}
         users = User.objects.filter(**queries).filter(is_active=True)
         if users.exists():
-            users_name = users.values_list('username', flat=True)
-            response_data.update({'status': 200, 'data': users_name})
+            usernames = users.values_list('username', flat=True)
+            usernames = json.dumps(list(usernames))
+            response_data.update({'status': 200, 'data': usernames})
             return JsonResponse(response_data)
 
         error_message = _('No users registered as `%(username)s` '
@@ -79,4 +83,4 @@ def markdown_search_user(request):
         error_message = _('Validation Failed for field `username`')
         response_data.update({'status': 204, 'error': error_message})
 
-    return JsonResponse(response_data)
+    return JsonResponse(response_data, encoder=LazyEncoder)

martor/views.py

@@ -57,7 +57,7 @@ def render(self, name, value, attrs=None, renderer=None, **kwargs):
         emoji_enabled = MARTOR_ENABLE_CONFIGS.get('emoji') == 'true'
         mentions_enabled = MARTOR_ENABLE_CONFIGS.get('mention') == 'true'
 
-        widget = super(MartorWidget, self).render(name, value, attributes_to_pass)
+        widget = super().render(name, value, attributes_to_pass)
 
         return template.render({
             'martor': widget,
@@ -88,7 +88,8 @@ class Media:
             'martor/js/martor.%s.min.js' % selected_theme,
         )
 
-        # Adding the following scripts to the end of the tuple in case it affects behaviour.
+        # Adding the following scripts to the end
+        # of the tuple in case it affects behaviour.
         # spellcheck configuration
         if MARTOR_ENABLE_CONFIGS.get('spellcheck') == 'true':
             js = ('plugins/js/typo.js', 'plugins/js/spellcheck.js').__add__(js)

martor/widgets.py

@@ -38,10 +38,10 @@ def get_requirements():
         'Operating System :: OS Independent',
         'Programming Language :: JavaScript',
         'Programming Language :: Python',
-        'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
         'Programming Language :: Python :: 3.8',
+        'Programming Language :: Python :: 3.9',
         'Topic :: Software Development :: Libraries :: Python Modules',
         'License :: OSI Approved :: GNU General Public License v3 (GPLv3)',
     ],