Skip to content

Commit 9f407bb

Browse files
committed
Use version to set the webdriver version
1 parent 1907162 commit 9f407bb

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@ def rbe?
120120
end
121121

122122
def version
123-
ENV['WD_BROWSER_VERSION'] || :stable
123+
return 'stable' if WebDriver::Platform.windows?
124+
125+
ENV['WD_BROWSER_VERSION'] || 'stable'
124126
end
125127

126128
def reset_remote_server
@@ -270,7 +272,7 @@ def safari_preview_driver(**opts)
270272
end
271273

272274
def chrome_options(args: [], **opts)
273-
opts[:browser_version] = 'stable' if WebDriver::Platform.windows?
275+
opts[:browser_version] = version
274276
opts[:web_socket_url] = true if ENV['WEBDRIVER_BIDI'] && !opts.key?(:web_socket_url)
275277
opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY')
276278
args << '--headless=chrome' if ENV['HEADLESS']
@@ -280,7 +282,7 @@ def chrome_options(args: [], **opts)
280282
end
281283

282284
def edge_options(args: [], **opts)
283-
opts[:browser_version] = 'stable' if WebDriver::Platform.windows?
285+
opts[:browser_version] = version
284286
opts[:web_socket_url] = true if ENV['WEBDRIVER_BIDI'] && !opts.key?(:web_socket_url)
285287
opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
286288
args << '--headless=chrome' if ENV['HEADLESS']
@@ -290,7 +292,7 @@ def edge_options(args: [], **opts)
290292
end
291293

292294
def firefox_options(args: [], **opts)
293-
opts[:browser_version] = 'stable' if WebDriver::Platform.windows?
295+
opts[:browser_version] = version
294296
opts[:web_socket_url] = true if ENV['WEBDRIVER_BIDI'] && !opts.key?(:web_socket_url)
295297
opts[:binary] ||= ENV['FIREFOX_BINARY'] if ENV.key?('FIREFOX_BINARY')
296298
args << '--headless' if ENV['HEADLESS']

0 commit comments

Comments
 (0)