feat: alert_color tty support, use rustc_hash instead std::hash

Author: ahabhgk

Cargo.toml

@@ -6,11 +6,11 @@ edition = "2021"
 [dependencies]
 prost = "0.10"
 url = "2"
-supports-color = "1"
+atty = "0.2"
 parking_lot = "0.12"
 dashmap = "5"
 crossbeam-channel = "0.5"
-
+rustc-hash = "1"
 
 [build-dependencies]
 prost-build = "0.10"

src/embedded.rs

@@ -1,5 +1,7 @@
 use std::ffi::OsStr;
 
+use atty::Stream;
+
 use crate::{
   channel::Channel,
   host::ImporterRegistry,
@@ -47,7 +49,7 @@ impl Embedded {
     let request = CompileRequest {
       style: options.style as i32,
       source_map: options.source_map,
-      alert_color: options.alert_color,
+      alert_color: options.alert_color.unwrap_or(atty::is(Stream::Stdout)),
       alert_ascii: options.alert_ascii,
       verbose: options.verbose,
       quiet_deps: options.quiet_deps,
@@ -84,7 +86,10 @@ impl Embedded {
     let request = CompileRequest {
       style: options.common.style as i32,
       source_map: options.common.source_map,
-      alert_color: options.common.alert_color,
+      alert_color: options
+        .common
+        .alert_color
+        .unwrap_or(atty::is(Stream::Stdout)),
       alert_ascii: options.common.alert_ascii,
       verbose: options.common.verbose,
       quiet_deps: options.common.quiet_deps,

src/host/importer_registry.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+use rustc_hash::FxHashMap;
 
 use crate::{
   options::{FileImporter, Importer, ImporterOptions, SassImporter},
@@ -20,9 +20,9 @@ pub struct ImporterRegistry {
   /// The next ID to use for an importer.
   id: u32,
   /// A map from importer IDs to their corresponding importers.
-  importers_by_id: HashMap<u32, Box<dyn Importer>>,
+  importers_by_id: FxHashMap<u32, Box<dyn Importer>>,
   /// A map from file importer IDs to their corresponding importers.
-  file_importers_by_id: HashMap<u32, Box<dyn FileImporter>>,
+  file_importers_by_id: FxHashMap<u32, Box<dyn FileImporter>>,
 }
 
 impl ImporterRegistry {

src/options.rs

@@ -1,10 +1,8 @@
 use std::fmt::Debug;
 
-use url::Url;
-
 use crate::{
   protocol::{OutputStyle, SourceSpan, Syntax},
-  Result,
+  Result, Url,
 };
 
 /// https://sass-lang.com/documentation/js-api/interfaces/Options
@@ -13,7 +11,7 @@ pub struct Options {
   /// https://sass-lang.com/documentation/js-api/interfaces/Options#alertAscii
   pub alert_ascii: bool,
   /// https://sass-lang.com/documentation/js-api/interfaces/Options#alertColor
-  pub alert_color: bool,
+  pub alert_color: Option<bool>,
   // /// https://sass-lang.com/documentation/js-api/interfaces/Options#functions
   // pub functions
   /// https://sass-lang.com/documentation/js-api/interfaces/Options#importers
@@ -40,7 +38,7 @@ impl Default for Options {
   fn default() -> Self {
     Self {
       alert_ascii: false,
-      alert_color: false,
+      alert_color: None,
       load_paths: None,
       importers: None,
       logger: None,
@@ -74,7 +72,7 @@ impl OptionsBuilder {
   }
 
   pub fn alert_color(mut self, arg: bool) -> Self {
-    self.options.alert_color = arg;
+    self.options.alert_color = Some(arg);
     self
   }
 
@@ -241,7 +239,7 @@ impl StringOptionsBuilder {
   }
 
   pub fn alert_color(mut self, arg: bool) -> Self {
-    self.options.alert_color = arg;
+    self.options.alert_color = Some(arg);
     self
   }