Skip to content

Commit adb23bc

Browse files
committed
[gdb/testsuite, tclint] Drop lreverse
When running tclint with lib/future.exp, I get: ... $ tclint lib/future.exp $exp:756:5: redefinition of built-in command 'lreverse' [redefined-builtin] ... The code was added to handle pre-7.5 tcl versions without lreverse. Since we now require Tcl 8.6.2 (as per PR testsuite/33205), drop this. Tested by rerunning tclint. Approved-By: Simon Marchi <[email protected]> PR testsuite/33403 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33403
1 parent 2517917 commit adb23bc

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

gdb/testsuite/lib/future.exp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -749,19 +749,6 @@ if { [array size use_gdb_compile] != 0 } {
749749
rename gdb_default_target_compile ""
750750
}
751751

752-
753-
# Provide 'lreverse' missing in Tcl before 7.5.
754-
755-
if {[info procs lreverse] == ""} {
756-
proc lreverse { arg } {
757-
set retval {}
758-
while { [llength $retval] < [llength $arg] } {
759-
lappend retval [lindex $arg end-[llength $retval]]
760-
}
761-
return $retval
762-
}
763-
}
764-
765752
# Various ccache versions provide incorrect debug info such as ignoring
766753
# different current directory, breaking GDB testsuite.
767754
set env(CCACHE_DISABLE) 1

0 commit comments

Comments
 (0)