Add nbval dependency and improve test coverage

- Add nbval>=0.10.0 to requirements-dev.txt for notebook validation
- Enhance automated checker with comprehensive repository tests
- Test all critical repository functionality including corrupted file handling
- Verify existing file loading and SQLite in-memory database persistence

Author: ahmadhasan2k8

check_and_fix.py

@@ -168,28 +168,65 @@ def check_test_functionality():
         else:
             print("✅ SQLite repository works")
 
-        # Test JsonFile repository
+        # Test JsonFile repository with existing file (the failing test case)
         result = run_command("""python3 -c "
 import sys, tempfile, os, json
 sys.path.append('src')
 from patterns.repository import JsonFileUserRepository
 with tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.json') as f:
-    json.dump({'users': [], 'next_id': 1}, f)
+    test_data = {
+        'users': [
+            {
+                'id': 1,
+                'name': 'Alice',
+                'email': 'alice@example.com',
+                'created_at': '2023-01-01T12:00:00',
+            }
+        ],
+        'next_id': 2,
+    }
+    json.dump(test_data, f)
+    temp_path = f.name
+try:
+    repo = JsonFileUserRepository(temp_path)
+    assert len(repo._users) == 1
+    assert repo._next_id == 2
+    assert repo._users[0].name == 'Alice'
+    print('JsonFile repository existing file test works')
+finally:
+    os.unlink(temp_path)
+" """, check=False)
+        
+        if result.returncode != 0:
+            print("❌ JsonFile repository existing file test failed")
+            print(result.stderr)
+            return False
+        else:
+            print("✅ JsonFile repository existing file test works")
+        
+        # Test corrupted file handling
+        result = run_command("""python3 -c "
+import sys, tempfile, os
+sys.path.append('src')
+from patterns.repository import JsonFileUserRepository
+with tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.json') as f:
+    f.write('invalid json content')
     temp_path = f.name
 try:
     repo = JsonFileUserRepository(temp_path)
     assert len(repo._users) == 0
-    print('JsonFile repository works')
+    assert repo._next_id == 1
+    print('Corrupted file handling works')
 finally:
     os.unlink(temp_path)
 " """, check=False)
 
         if result.returncode != 0:
-            print("❌ JsonFile repository test failed")
+            print("❌ Corrupted file handling test failed")
             print(result.stderr)
             return False
         else:
-            print("✅ JsonFile repository works")
+            print("✅ Corrupted file handling works")
 
         return True
 

requirements-dev.txt

@@ -5,6 +5,7 @@
 pytest>=7.4.0
 pytest-cov>=4.1.0
 pytest-xdist>=3.3.0
+nbval>=0.10.0
 
 # Code quality
 black>=23.7.0