Sema: Remove Constraint::clone()

Author: slavapestov

include/swift/Sema/Constraint.h

@@ -904,9 +904,6 @@ class Constraint final : public llvm::ilist_node<Constraint>,
   /// Retrieve the locator for this constraint.
   ConstraintLocator *getLocator() const { return Locator; }
 
-  /// Clone the given constraint.
-  Constraint *clone(ConstraintSystem &cs) const;
-
   /// Print constraint placed on type and constraint properties.
   ///
   /// \c skipLocator skips printing of locators.

lib/Sema/Constraint.cpp

@@ -300,85 +300,6 @@ ProtocolDecl *Constraint::getProtocol() const {
   return Types.Second->castTo<ProtocolType>()->getDecl();
 }
 
-Constraint *Constraint::clone(ConstraintSystem &cs) const {
-  switch (getKind()) {
-  case ConstraintKind::Bind:
-  case ConstraintKind::Equal:
-  case ConstraintKind::BindParam:
-  case ConstraintKind::BindToPointerType:
-  case ConstraintKind::Subtype:
-  case ConstraintKind::Conversion:
-  case ConstraintKind::BridgingConversion:
-  case ConstraintKind::ArgumentConversion:
-  case ConstraintKind::OperatorArgumentConversion:
-  case ConstraintKind::SubclassOf:
-  case ConstraintKind::ConformsTo:
-  case ConstraintKind::LiteralConformsTo:
-  case ConstraintKind::TransitivelyConformsTo:
-  case ConstraintKind::CheckedCast:
-  case ConstraintKind::DynamicTypeOf:
-  case ConstraintKind::EscapableFunctionOf:
-  case ConstraintKind::OpenedExistentialOf:
-  case ConstraintKind::SelfObjectOfProtocol:
-  case ConstraintKind::DynamicCallableApplicableFunction:
-  case ConstraintKind::OptionalObject:
-  case ConstraintKind::Defaultable:
-  case ConstraintKind::OneWayEqual:
-  case ConstraintKind::OneWayBindParam:
-  case ConstraintKind::FallbackType:
-  case ConstraintKind::UnresolvedMemberChainBase:
-  case ConstraintKind::PropertyWrapper:
-  case ConstraintKind::BindTupleOfFunctionParams:
-  case ConstraintKind::PackElementOf:
-  case ConstraintKind::ShapeOf:
-  case ConstraintKind::ExplicitGenericArguments:
-  case ConstraintKind::SameShape:
-  case ConstraintKind::MaterializePackExpansion:
-  case ConstraintKind::LValueObject:
-    return create(cs, getKind(), getFirstType(), getSecondType(), getLocator());
-
-  case ConstraintKind::ApplicableFunction:
-    return createApplicableFunction(
-        cs, getFirstType(), getSecondType(), getTrailingClosureMatching(),
-        getLocator());
-
-  case ConstraintKind::BindOverload:
-    return createBindOverload(cs, getFirstType(), getOverloadChoice(),
-                              getOverloadUseDC(), getLocator());
-
-  case ConstraintKind::ValueMember:
-  case ConstraintKind::UnresolvedValueMember:
-    return createMember(cs, getKind(), getFirstType(), getSecondType(),
-                        getMember(), getMemberUseDC(), getFunctionRefKind(),
-                        getLocator());
-
-  case ConstraintKind::ValueWitness:
-    return createValueWitness(
-        cs, getKind(), getFirstType(), getSecondType(), getRequirement(),
-        getMemberUseDC(), getFunctionRefKind(), getLocator());
-
-  case ConstraintKind::Disjunction:
-    return createDisjunction(
-        cs, getNestedConstraints(), getLocator(),
-        static_cast<RememberChoice_t>(shouldRememberChoice()));
-
-  case ConstraintKind::Conjunction:
-    return createConjunction(cs, getNestedConstraints(), IsIsolated,
-                             getLocator(), getTypeVariables());
-
-  case ConstraintKind::KeyPath:
-  case ConstraintKind::KeyPathApplication:
-    return create(cs, getKind(), getFirstType(), getSecondType(), getThirdType(),
-                  getLocator());
-
-  case ConstraintKind::SyntacticElement:
-    return createSyntacticElement(cs, getSyntacticElement(), getLocator(),
-                                  isDiscardedElement());
-  }
-
-  llvm_unreachable("Unhandled ConstraintKind in switch.");
-}
-
 void Constraint::print(llvm::raw_ostream &Out, SourceManager *sm,
                        unsigned indent, bool skipLocator) const {
   // Print all type variables as $T0 instead of _ here.