slack: minor

Author: rr0gi

lib/slack.ml

@@ -26,6 +26,7 @@ let empty_attachments =
 let mrkdwn_of_markdown str = String.strip @@ Mrkdwn.mrkdwn_of_markdown str
 let mrkdwn_of_markdown_opt = Option.map ~f:mrkdwn_of_markdown
 let escape = Mrkdwn.escape_mrkdwn
+let pp_link ~url text = sprintf "<%s|%s>" url (escape text)
 
 let show_labels = function
   | [] -> None
@@ -50,8 +51,8 @@ let generate_pull_request_notification notification channel =
         )
   in
   let summary =
-    sprintf "<%s|[%s]> Pull request #%d <%s|%s> %s by *%s*" repository.url repository.full_name number html_url
-      (escape title) action sender.login
+    sprintf "<%s|[%s]> Pull request #%d %s %s by *%s*" repository.url repository.full_name number
+      (pp_link ~url:html_url title) action sender.login
   in
   {
     channel;
@@ -88,8 +89,8 @@ let generate_pr_review_notification notification channel =
         )
   in
   let summary =
-    sprintf "<%s|[%s]> *%s* <%s|%s> #%d <%s|%s>" repository.url repository.full_name sender.login review.html_url
-      action_str number html_url (escape title)
+    sprintf "<%s|[%s]> *%s* <%s|%s> #%d %s" repository.url repository.full_name sender.login review.html_url
+      action_str number (pp_link ~url:html_url title)
   in
   {
     channel;
@@ -120,8 +121,8 @@ let generate_pr_review_comment_notification notification channel =
         )
   in
   let summary =
-    sprintf "<%s|[%s]> *%s* %s on #%d <%s|%s>" repository.url repository.full_name sender.login action_str number
-      html_url (escape title)
+    sprintf "<%s|[%s]> *%s* %s on #%d %s" repository.url repository.full_name sender.login action_str number
+      (pp_link ~url:html_url title)
   in
   let file =
     match comment.path with
@@ -161,7 +162,7 @@ let generate_issue_notification notification channel =
         )
   in
   let summary =
-    sprintf "<%s|[%s]> Issue #%d <%s|%s> %s by *%s*" repository.url repository.full_name number html_url (escape title)
+    sprintf "<%s|[%s]> Issue #%d %s %s by *%s*" repository.url repository.full_name number (pp_link ~url:html_url title)
       action sender.login
   in
   {
@@ -194,8 +195,8 @@ let generate_issue_comment_notification notification channel =
         )
   in
   let summary =
-    sprintf "<%s|[%s]> *%s* <%s|%s> on #%d <%s|%s>" repository.url repository.full_name sender.login comment.html_url
-      action_str number issue.html_url (escape title)
+    sprintf "<%s|[%s]> *%s* <%s|%s> on #%d %s" repository.url repository.full_name sender.login comment.html_url
+      action_str number (pp_link ~url:issue.html_url title)
   in
   {
     channel;
@@ -342,8 +343,8 @@ let generate_commit_comment_notification api_commit notification channel =
     | Some c -> c
   in
   let summary =
-    sprintf "<%s|[%s]> *%s* commented on `<%s|%s>` %s" repository.url repository.full_name sender.login comment.html_url
-      (git_short_sha_hash commit_id)
+    sprintf "<%s|[%s]> *%s* commented on `%s` %s" repository.url repository.full_name sender.login (pp_link ~url:comment.html_url
+      (git_short_sha_hash commit_id))
       (first_line (escape commit.message))
   in
   let path =