make fields short and space-pad list fields

Author: yasunariw

lib/slack.atd

@@ -3,6 +3,7 @@ type 'v map_as_object <ocaml from="State"> = abstract
 type message_field = {
   ?title: string nullable;
   value: string;
+  ~short <ocaml default="false">: bool;
 }
 
 type message_attachment = {

lib/slack.ml

@@ -259,7 +259,7 @@ let generate_push_notification notification channel =
             mrkdwn_in = Some [ "fields" ];
             fallback = Some "Commit pushed notification";
             color = Some "#ccc";
-            fields = Some [ { value = String.concat ~sep:"\n" commits; title = None } ];
+            fields = Some [ { value = String.concat ~sep:"\n" commits; title = None; short = false } ];
           };
         ];
     blocks = None;
@@ -315,6 +315,7 @@ let generate_status_notification (cfg : Config_t.config) (notification : status_
         (sprintf "<%s|[%s]> CI Build Status notification for <%s|%s>: %s" repository.url repository.full_name t context
            state_info)
   in
+  let msg = String.concat ~sep:"\n" @@ List.concat [ commit_info; branches_info ] in
   let attachment =
     {
       empty_attachments with
@@ -323,7 +324,7 @@ let generate_status_notification (cfg : Config_t.config) (notification : status_
       pretext = summary;
       color = Some color_info;
       text = description_info;
-      fields = Some [ { title = None; value = String.concat ~sep:"\n" @@ List.concat [ commit_info; branches_info ] } ];
+      fields = Some [ { title = None; value = msg; short = false } ];
     }
   in
   { channel; text = None; attachments = Some [ attachment ]; blocks = None }

lib/slack_message.ml

@@ -77,8 +77,8 @@ let populate_pull_request repository (pull_request : pull_request) =
       "Comments", [ Int.to_string comments ];
       "Reviewers", get_reviewers ();
     ]
-    |> List.filter_map ~f:(fun (t, v) -> if List.is_empty v then None else Some (t, String.concat v ~sep:","))
-    |> List.map ~f:(fun (t, v) -> { title = Some t; value = v })
+    |> List.filter_map ~f:(fun (t, v) -> if List.is_empty v then None else Some (t, String.concat v ~sep:", "))
+    |> List.map ~f:(fun (t, v) -> { title = Some t; value = v; short = true })
   in
   let get_title () = sprintf "#%d %s" number (Mrkdwn.escape_mrkdwn title) in
   {
@@ -103,8 +103,8 @@ let populate_issue repository (issue : issue) =
       "Labels", List.map labels ~f:pp_label;
       "Comments", [ Int.to_string comments ];
     ]
-    |> List.filter_map ~f:(fun (t, v) -> if List.is_empty v then None else Some (t, String.concat v ~sep:","))
-    |> List.map ~f:(fun (t, v) -> { title = Some t; value = v })
+    |> List.filter_map ~f:(fun (t, v) -> if List.is_empty v then None else Some (t, String.concat v ~sep:", "))
+    |> List.map ~f:(fun (t, v) -> { title = Some t; value = v; short = true })
   in
   let get_title () = sprintf "#%d %s" number (Mrkdwn.escape_mrkdwn title) in
   {