slack: construct body in api call

Author: yasunariw

lib/action.ml

@@ -331,8 +331,7 @@ module Action (Github_api : Api.Github) (Slack_api : Api.Slack) = struct
       let%lwt unfurls = List.map links ~f:process |> Lwt.all |> Lwt.map List.filter_opt |> Lwt.map StringMap.of_list in
       if Map.is_empty unfurls then Lwt.return "ignored: no links to unfurl"
       else begin
-        let req : Slack_j.chat_unfurl_req = { channel = event.channel; ts = event.message_ts; unfurls } in
-        match%lwt Slack_api.send_chat_unfurl ~ctx req with
+        match%lwt Slack_api.send_chat_unfurl ~ctx ~channel:event.channel ~ts:event.message_ts ~unfurls () with
         | Ok () -> Lwt.return "ok"
         | Error e ->
           log#error "%s" e;

lib/api.ml

@@ -18,6 +18,14 @@ end
 
 module type Slack = sig
   val send_notification : ctx:Context.t -> msg:post_message_req -> unit slack_response Lwt.t
-  val send_chat_unfurl : ctx:Context.t -> chat_unfurl_req -> unit slack_response Lwt.t
+
+  val send_chat_unfurl
+    :  ctx:Context.t ->
+    channel:string ->
+    ts:string ->
+    unfurls:message_attachment Common.StringMap.t ->
+    unit ->
+    unit slack_response Lwt.t
+
   val send_auth_test : ctx:Context.t -> unit -> auth_test_res slack_response Lwt.t
 end

lib/api_local.ml

@@ -25,7 +25,7 @@ end
 
 module Slack_base : Api.Slack = struct
   let send_notification ~ctx:_ ~msg:_ = Lwt.return @@ Error "undefined for local setup"
-  let send_chat_unfurl ~ctx:_ _ = Lwt.return @@ Error "undefined for local setup"
+  let send_chat_unfurl ~ctx:_ ~channel:_ ~ts:_ ~unfurls:_ () = Lwt.return @@ Error "undefined for local setup"
   let send_auth_test ~ctx:_ () = Lwt.return @@ Error "undefined for local setup"
 end
 

lib/api_remote.ml

@@ -139,7 +139,8 @@ module Slack : Api.Slack = struct
         | Error e -> Lwt.return @@ build_error e
       end
 
-  let send_chat_unfurl ~(ctx : Context.t) req =
+  let send_chat_unfurl ~(ctx : Context.t) ~channel ~ts ~unfurls () =
+    let req = Slack_j.{ channel; ts; unfurls } in
     let data = Slack_j.string_of_chat_unfurl_req req in
     request_token_auth ~name:"unfurl slack links"
       ~body:(`Raw ("application/json", data))