switch to standalone base64 lib

Author: rr0gi

lib/api_remote.ml

@@ -34,10 +34,10 @@ module Github : Api.Github = struct
           try
             response.content |> String.split_lines |> String.concat |> decode_string_pad |> Config_j.config_of_string
             |> fun res -> Lwt.return @@ Ok res
-          with Base64.Invalid_char as exn ->
+          with exn ->
             let e = Exn.to_string exn in
             Lwt.return
-            @@ fmt_error "error while decoding base64 in GitHub response: %s\nfailed to get config from file %s" e url
+            @@ fmt_error "error while reading config from GitHub response: %s\nfailed to get config from file %s" e url
         end
       | encoding ->
         Lwt.return

lib/common.ml

@@ -23,7 +23,7 @@ let first_line s =
   | [] -> s
 
 let decode_string_pad s =
-  String.rstrip ~drop:(List.mem [ '='; ' '; '\n'; '\r'; '\t' ] ~equal:Char.equal) s |> Base64.decode_string
+  String.rstrip ~drop:(List.mem [ '='; ' '; '\n'; '\r'; '\t' ] ~equal:Char.equal) s |> Base64.decode_exn ~pad:false
 
 let http_request ?headers ?body meth path =
   match%lwt Web.http_request_lwt ~ua:"monorobot" ~verbose:true ?headers ?body meth path with

lib/dune

@@ -1,6 +1,6 @@
 (library
  (name lib)
- (libraries atdgen atdgen-runtime base base.caml biniou cstruct curl curl.lwt
+ (libraries atdgen atdgen-runtime base base64 base.caml biniou cstruct curl curl.lwt
    devkit devkit.core extlib hex lwt lwt.unix nocrypto omd re stdio uri
    yojson)
  (preprocess

monorobot.opam

@@ -13,6 +13,7 @@ depends: [
  "dune" {>= "2.5.0"}
  "atdgen"
  "base"
+ "base64"
  "biniou"
  "cmdliner"
  "cstruct"