Skip to content

Commit 024b92b

Browse files
styles:dark mode color fix (#11004)
1 parent f23b63c commit 024b92b

File tree

6 files changed

+24
-22
lines changed

6 files changed

+24
-22
lines changed

apps/storybook/styles/storybook-styles.css

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,10 @@
248248
--cal-bg-inverted: #f3f4f6;
249249

250250
/* background -> components*/
251-
--cal-bg-info: #dee9fc;
252-
--cal-bg-success: #e2fbe8;
253-
--cal-bg-attention: #fceed8;
254-
--cal-bg-error: #f9e3e2;
251+
--cal-bg-info: #263fa9;
252+
--cal-bg-success: #306339;
253+
--cal-bg-attention: #8e3b1f;
254+
--cal-bg-error: #8c2822;
255255
--cal-bg-dark-error: #752522;
256256

257257
/* Borders */
@@ -269,10 +269,10 @@
269269
--cal-text-inverted: #101010;
270270

271271
/* Content/Text -> components */
272-
--cal-text-info: #253985;
273-
--cal-text-success: #285231;
274-
--cal-text-attention: #73321b;
275-
--cal-text-error: #752522;
272+
--cal-text-info: #dee9fc;
273+
--cal-text-success: #e2fbe8;
274+
--cal-text-attention: #fceed8;
275+
--cal-text-error: #f9e3e2;
276276

277277
/* Brand shenanigans
278278
-> These will be computed for the users theme at runtime.

apps/web/styles/globals.css

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@
5858
--cal-bg-inverted: #f3f4f6;
5959

6060
/* background -> components*/
61-
--cal-bg-info: #dee9fc;
62-
--cal-bg-success: #e2fbe8;
63-
--cal-bg-attention: #fceed8;
64-
--cal-bg-error: #f9e3e2;
61+
--cal-bg-info: #263fa9;
62+
--cal-bg-success: #306339;
63+
--cal-bg-attention: #8e3b1f;
64+
--cal-bg-error: #8c2822;
6565
--cal-bg-dark-error: #752522;
6666

6767
/* Borders */
@@ -80,10 +80,10 @@
8080
--cal-text-inverted: #101010;
8181

8282
/* Content/Text -> components */
83-
--cal-text-info: #253985;
84-
--cal-text-success: #285231;
85-
--cal-text-attention: #73321b;
86-
--cal-text-error: #752522;
83+
--cal-text-info: #dee9fc;
84+
--cal-text-success: #e2fbe8;
85+
--cal-text-attention: #fceed8;
86+
--cal-text-error: #f9e3e2;
8787

8888
/* Brand shenanigans
8989
-> These will be computed for the users theme at runtime.

packages/features/ee/teams/components/TeamPill.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ export default function TeamPill(props: Props) {
1515
<div
1616
className={classNames("text-medium self-center rounded-md px-1 py-0.5 text-xs ltr:mr-1 rtl:ml-1", {
1717
" bg-subtle text-emphasis": !props.color,
18-
" bg-info text-blue-800": props.color === "blue",
19-
" bg-error text-red-800 ": props.color === "red",
20-
" bg-attention text-orange-800": props.color === "orange",
18+
" bg-info text-info": props.color === "blue",
19+
" bg-error text-error ": props.color === "red",
20+
" bg-attention text-attention": props.color === "orange",
2121
})}>
2222
{props.text}
2323
</div>

packages/ui/components/button/Button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const buttonClasses = cva(
5252
minimal:
5353
"text-emphasis hover:bg-subtle focus-visible:bg-subtle focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset focus-visible:ring-empthasis disabled:border-subtle disabled:bg-opacity-30 disabled:text-muted disabled:hover:bg-transparent disabled:hover:text-muted disabled:hover:border-subtle",
5454
destructive:
55-
"border border-default text-emphasis hover:text-red-700 focus-visible:text-red-700 hover:border-red-100 focus-visible:border-red-100 hover:bg-error focus-visible:bg-error focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset focus-visible:ring-red-700 disabled:bg-red-100 disabled:border-red-200 disabled:text-red-700 disabled:hover:border-red-200 disabled:opacity-40",
55+
"border border-default text-emphasis hover:text-red-700 dark:hover:text-red-100 focus-visible:text-red-700 hover:border-red-100 focus-visible:border-red-100 hover:bg-error focus-visible:bg-error focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset focus-visible:ring-red-700 disabled:bg-red-100 disabled:border-red-200 disabled:text-red-700 disabled:hover:border-red-200 disabled:opacity-40",
5656
},
5757
size: {
5858
sm: "px-3 py-2 leading-4 rounded-sm" /** For backwards compatibility */,

packages/ui/components/dialog/ConfirmationDialogContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export function ConfirmationDialogContent(props: PropsWithChildren<ConfirmationD
4141
<div className="mt-0.5 ltr:mr-3">
4242
{variety === "danger" && (
4343
<div className="bg-error mx-auto rounded-full p-2 text-center">
44-
<AlertCircle className="h-5 w-5 text-red-600" />
44+
<AlertCircle className="h-5 w-5 text-red-600 dark:text-red-100" />
4545
</div>
4646
)}
4747
{variety === "warning" && (

packages/ui/components/form/dropdown/Dropdown.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,9 @@ export const DropdownItem = (props: DropdownItemProps) => {
138138
{...rest}
139139
className={classNames(
140140
"hover:text-emphasis text-default inline-flex w-full items-center space-x-2 px-3 py-2 disabled:cursor-not-allowed",
141-
color === "destructive" ? "hover:bg-error hover:text-red-700" : "hover:bg-subtle",
141+
color === "destructive"
142+
? "hover:bg-error hover:text-red-700 dark:hover:text-red-100"
143+
: "hover:bg-subtle",
142144
props.className
143145
)}>
144146
<>

0 commit comments

Comments
 (0)