Remove unnecessary AbstractConfigPropertySynchronizer class (#33002)

Closes #33000

Signed-off-by: Stefan Guilhen <[email protected]>

Author: sguilhen

server-spi-private/src/main/java/org/keycloak/broker/provider/mappersync/AbstractConfigPropertySynchronizer.java

@@ -17,6 +17,7 @@
 
 package org.keycloak.broker.provider.mappersync;
 
+import org.jboss.logging.Logger;
 import org.keycloak.models.IdentityProviderMapperModel;
 import org.keycloak.models.KeycloakSession;
 import org.keycloak.models.RealmModel;
@@ -28,7 +29,17 @@
  * @author <a href="mailto:[email protected]">Daniel Fesenmeyer</a>
  */
 public interface ConfigSynchronizer<T extends ProviderEvent> {
+    Logger LOG = Logger.getLogger(ConfigSynchronizer.class);
+
     Class<T> getEventClass();
 
     void handleEvent(T event);
+
+    default void logEventProcessed(String configPropertyName, String previousValue, String newValue, String realmName,
+                                     String mapperName, String idpAlias) {
+        LOG.infof(
+                "Reference of type '%s' changed from '%s' to '%s' in realm '%s'. Adjusting the reference from mapper '%s' of IDP '%s'.",
+                configPropertyName, previousValue, newValue, realmName, mapperName, idpAlias);
+
+    }
 }

server-spi-private/src/main/java/org/keycloak/broker/provider/mappersync/ConfigSynchronizer.java

@@ -33,7 +33,7 @@
  *
  * @author <a href="mailto:[email protected]">Daniel Fesenmeyer</a>
  */
-public class GroupConfigPropertyByPathSynchronizer extends AbstractConfigPropertySynchronizer<GroupModel.GroupPathChangeEvent> {
+public class GroupConfigPropertyByPathSynchronizer implements ConfigSynchronizer<GroupModel.GroupPathChangeEvent> {
 
     public static final GroupConfigPropertyByPathSynchronizer INSTANCE = new GroupConfigPropertyByPathSynchronizer();
 
@@ -53,7 +53,7 @@ public void handleEvent(GroupModel.GroupPathChangeEvent event) {
         event.getKeycloakSession().identityProviders().getMappersStream(Map.of(ConfigConstants.GROUP, event.getPreviousPath()), null, null)
                 .forEach(idpMapper -> {
                     idpMapper.getConfig().put(ConfigConstants.GROUP, event.getNewPath());
-                    super.logEventProcessed(ConfigConstants.GROUP, event.getPreviousPath(), event.getNewPath(), event.getRealm().getName(),
+                    logEventProcessed(ConfigConstants.GROUP, event.getPreviousPath(), event.getNewPath(), event.getRealm().getName(),
                             idpMapper.getName(), idpMapper.getIdentityProviderAlias());
                     event.getKeycloakSession().identityProviders().updateMapper(idpMapper);
                 });
@@ -65,7 +65,7 @@ public void handleEvent(GroupModel.GroupPathChangeEvent event) {
                     String currentGroupPath = idpMapper.getConfig().get(ConfigConstants.GROUP);
                     String newGroupPath = event.getNewPath() + currentGroupPath.substring(event.getPreviousPath().length());
                     idpMapper.getConfig().put(ConfigConstants.GROUP, newGroupPath);
-                    super.logEventProcessed(ConfigConstants.GROUP, currentGroupPath, newGroupPath, event.getRealm().getName(),
+                    logEventProcessed(ConfigConstants.GROUP, currentGroupPath, newGroupPath, event.getRealm().getName(),
                             idpMapper.getName(), idpMapper.getIdentityProviderAlias());
                     event.getKeycloakSession().identityProviders().updateMapper(idpMapper);
                 });

server-spi-private/src/main/java/org/keycloak/broker/provider/mappersync/GroupConfigPropertyByPathSynchronizer.java

@@ -31,7 +31,7 @@
  *
  * @author <a href="mailto:[email protected]">Daniel Fesenmeyer</a>
  */
-public class RoleConfigPropertyByClientIdSynchronizer extends AbstractConfigPropertySynchronizer<ClientModel.ClientIdChangeEvent> {
+public class RoleConfigPropertyByClientIdSynchronizer implements ConfigSynchronizer<ClientModel.ClientIdChangeEvent> {
 
     public static final RoleConfigPropertyByClientIdSynchronizer INSTANCE =
             new RoleConfigPropertyByClientIdSynchronizer();
@@ -54,7 +54,7 @@ public void handleEvent(ClientModel.ClientIdChangeEvent event) {
                     String configuredRoleName = KeycloakModelUtils.parseRole(currentRoleValue)[1];
                     String newRoleValue = KeycloakModelUtils.buildRoleQualifier(event.getNewClientId(), configuredRoleName);
                     idpMapper.getConfig().put(ConfigConstants.ROLE, newRoleValue);
-                    super.logEventProcessed(ConfigConstants.ROLE, currentRoleValue, newRoleValue, event.getUpdatedClient().getRealm().getName(),
+                    logEventProcessed(ConfigConstants.ROLE, currentRoleValue, newRoleValue, event.getUpdatedClient().getRealm().getName(),
                             idpMapper.getName(), idpMapper.getIdentityProviderAlias());
                     event.getKeycloakSession().identityProviders().updateMapper(idpMapper);
                 });

server-spi-private/src/main/java/org/keycloak/broker/provider/mappersync/RoleConfigPropertyByClientIdSynchronizer.java

@@ -31,8 +31,7 @@
  *
  * @author <a href="mailto:[email protected]">Daniel Fesenmeyer</a>
  */
-public class RoleConfigPropertyByRoleNameSynchronizer
-        extends AbstractConfigPropertySynchronizer<RoleModel.RoleNameChangeEvent> {
+public class RoleConfigPropertyByRoleNameSynchronizer implements ConfigSynchronizer<RoleModel.RoleNameChangeEvent> {
 
     public static final RoleConfigPropertyByRoleNameSynchronizer INSTANCE =
             new RoleConfigPropertyByRoleNameSynchronizer();
@@ -54,7 +53,7 @@ public void handleEvent(RoleModel.RoleNameChangeEvent event) {
                 .forEach(idpMapper -> {
                     String newRoleValue = KeycloakModelUtils.buildRoleQualifier(event.getClientId(), event.getNewName());
                     idpMapper.getConfig().put(ConfigConstants.ROLE, newRoleValue);
-                    super.logEventProcessed(ConfigConstants.ROLE, currentRoleValue, newRoleValue, event.getRealm().getName(),
+                    logEventProcessed(ConfigConstants.ROLE, currentRoleValue, newRoleValue, event.getRealm().getName(),
                             idpMapper.getName(), idpMapper.getIdentityProviderAlias());
                     event.getKeycloakSession().identityProviders().updateMapper(idpMapper);
                 });