Skip to content

Commit 8ca5513

Browse files
Updated modal titles and button names in Authentication flows (#37558)
* Updated modal titles and button names Signed-off-by: Agnieszka Gancarczyk <[email protected]> * Updated modal titles and button names Signed-off-by: Agnieszka Gancarczyk <[email protected]> * Adjusted test Signed-off-by: Agnieszka Gancarczyk <[email protected]> * Adjusted test Signed-off-by: Agnieszka Gancarczyk <[email protected]> * Adjusted test Signed-off-by: Agnieszka Gancarczyk <[email protected]> * Improved delete dialog Signed-off-by: Agnieszka Gancarczyk <[email protected]> --------- Signed-off-by: Agnieszka Gancarczyk <[email protected]>
1 parent c5f9917 commit 8ca5513

File tree

6 files changed

+18
-9
lines changed

6 files changed

+18
-9
lines changed

js/apps/admin-ui/cypress/support/pages/admin-ui/manage/authentication/FlowDetail.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default class FlowDetails {
6060
}
6161

6262
addExecution(subFlowName: string, executionTestId: string) {
63-
this.#clickEditDropdownForFlow(subFlowName, "Add step");
63+
this.#clickEditDropdownForFlow(subFlowName, "Add execution");
6464

6565
cy.get(".pf-v5-c-pagination").should("exist");
6666
cy.findByTestId(executionTestId).click();
@@ -93,7 +93,7 @@ export default class FlowDetails {
9393

9494
#fillSubFlowModal(subFlowName: string, name: string) {
9595
cy.get(".pf-v5-c-modal-box__title-text").contains(
96-
"Add step to " + subFlowName,
96+
"Add sub-flow to " + subFlowName,
9797
);
9898
cy.findByTestId("name").type(name);
9999
cy.findByTestId("modal-add").click();

js/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2000,7 +2000,7 @@ principalAttributeHelp=Name or Friendly Name of the attribute used to identify e
20002000
nameIdPolicyFormat=NameID policy format
20012001
idpInitiatedSsoUrlName=IDP-Initiated SSO URL name
20022002
selectMethod=Select method
2003-
deleteConfirmExecution=Delete execution?
2003+
deleteConfirmExecution=Delete flow {{name}}?
20042004
eventTypes.VALIDATE_ACCESS_TOKEN_ERROR.name=Validate access token error
20052005
xFrameOptions=X-Frame-Options
20062006
scopeDescriptionHelp=Description of the client scope
@@ -3418,4 +3418,7 @@ usersResources=Users
34183418
clientsResources=Clients
34193419
groupsResources=Groups
34203420
resourceTypeHelpText=Specifies which {{ resourceType }} are allowed by this permission.
3421-
evaluation=Evaluation
3421+
evaluation=Evaluation
3422+
addSubFlowTo=Add sub-flow to {{name}}
3423+
addExecutionTo=Add execution to {{name}}
3424+
addConditionTo=Add condition to {{name}}

js/apps/admin-ui/src/authentication/FlowDetails.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,9 @@ export default function FlowDetails() {
222222
};
223223

224224
const [toggleDeleteDialog, DeleteConfirm] = useConfirmDialog({
225-
titleKey: "deleteConfirmExecution",
225+
titleKey: t("deleteConfirmExecution", {
226+
name: selectedExecution?.displayName,
227+
}),
226228
children: (
227229
<Trans i18nKey="deleteConfirmExecutionMessage">
228230
{" "}
@@ -386,7 +388,7 @@ export default function FlowDetails() {
386388
variant="secondary"
387389
onClick={() => setShowAddExecutionDialog(true)}
388390
>
389-
{t("addStep")}
391+
{t("addExecution")}
390392
</Button>
391393
</ToolbarItem>
392394
<ToolbarItem>

js/apps/admin-ui/src/authentication/components/AddFlowDropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export const AddFlowDropdown = ({
7575
setType(providerId === "form-flow" ? "form" : "basic")
7676
}
7777
>
78-
{t("addStep")}
78+
{t("addExecution")}
7979
</DropdownItem>
8080
<DropdownItem
8181
key="addCondition"

js/apps/admin-ui/src/authentication/components/modals/AddStepModal.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ export const AddStepModal = ({ name, type, onSelect }: AddStepModalProps) => {
105105
<Modal
106106
variant={ModalVariant.medium}
107107
isOpen={true}
108-
title={t("addStepTo", { name })}
108+
title={
109+
type == "condition"
110+
? t("addConditionTo", { name })
111+
: t("addExecutionTo", { name })
112+
}
109113
onClose={() => onSelect()}
110114
actions={[
111115
<Button

js/apps/admin-ui/src/authentication/components/modals/AddSubFlowModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const AddSubFlowModal = ({
5858
return (
5959
<Modal
6060
variant={ModalVariant.medium}
61-
title={t("addStepTo", { name })}
61+
title={t("addSubFlowTo", { name })}
6262
onClose={onCancel}
6363
actions={[
6464
<Button

0 commit comments

Comments
 (0)