Skip to content

Commit 28e3db2

Browse files
feat(source-maps): Do not show pagination together with empty state (#92287)
1 parent d1684ca commit 28e3db2

File tree

1 file changed

+31
-26
lines changed

1 file changed

+31
-26
lines changed

static/app/views/settings/projectSourceMaps/sourceMapsList.tsx

Lines changed: 31 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ export function SourceMapsList({location, router, project}: Props) {
204204
deleteSourceMaps({bundleId: id, projectSlug: project.slug});
205205
}}
206206
docsLink={sourceMapsLinks.sourcemaps}
207+
pageLinks={headers?.('Link') ?? ''}
207208
/>
208-
<Pagination pageLinks={headers?.('Link') ?? ''} />
209209
</Fragment>
210210
);
211211
}
@@ -299,6 +299,7 @@ interface SourceMapUploadsListProps {
299299
onClearSearch: () => void;
300300
onDelete: (id: string) => void;
301301
project: Project;
302+
pageLinks?: string;
302303
query?: string;
303304
sourceMapUploads?: SourceMapUpload[];
304305
}
@@ -311,6 +312,7 @@ function SourceMapUploadsList({
311312
project,
312313
query,
313314
docsLink,
315+
pageLinks,
314316
}: SourceMapUploadsListProps) {
315317
const organization = useOrganization();
316318

@@ -337,31 +339,34 @@ function SourceMapUploadsList({
337339
}
338340

339341
return (
340-
<List>
341-
{sourceMapUploads.map(sourceMapUpload => (
342-
<Item key={sourceMapUpload.id}>
343-
<ItemHeader>
344-
<ItemTitle to={sourceMapUploadDetailLink(sourceMapUpload)}>
345-
<IconUpload />
346-
{tct('[date] ([fileCount] files)', {
347-
date: <DateTime year date={sourceMapUpload.date} />,
348-
fileCount: sourceMapUpload.fileCount,
349-
})}
350-
</ItemTitle>
351-
<SourceMapUploadDeleteButton
352-
onDelete={
353-
sourceMapUpload.type === 'debugId'
354-
? () => onDelete(sourceMapUpload.id)
355-
: undefined
356-
}
357-
/>
358-
</ItemHeader>
359-
<ItemContent>
360-
<SourceMapUploadDetails sourceMapUpload={sourceMapUpload} />
361-
</ItemContent>
362-
</Item>
363-
))}
364-
</List>
342+
<Fragment>
343+
<List>
344+
{sourceMapUploads.map(sourceMapUpload => (
345+
<Item key={sourceMapUpload.id}>
346+
<ItemHeader>
347+
<ItemTitle to={sourceMapUploadDetailLink(sourceMapUpload)}>
348+
<IconUpload />
349+
{tct('[date] ([fileCount] files)', {
350+
date: <DateTime year date={sourceMapUpload.date} />,
351+
fileCount: sourceMapUpload.fileCount,
352+
})}
353+
</ItemTitle>
354+
<SourceMapUploadDeleteButton
355+
onDelete={
356+
sourceMapUpload.type === 'debugId'
357+
? () => onDelete(sourceMapUpload.id)
358+
: undefined
359+
}
360+
/>
361+
</ItemHeader>
362+
<ItemContent>
363+
<SourceMapUploadDetails sourceMapUpload={sourceMapUpload} />
364+
</ItemContent>
365+
</Item>
366+
))}
367+
</List>
368+
<Pagination pageLinks={pageLinks} />
369+
</Fragment>
365370
);
366371
}
367372

0 commit comments

Comments
 (0)