ref(search): Be consistent about allowed spaces in lists (#26189)

Author: evanpurkhiser

src/sentry/api/event_search.py

@@ -112,8 +112,8 @@
 text_key         = explicit_tag_key / search_key
 text_value       = quoted_value / in_value
 quoted_value     = ~r"\"((?:\\\"|[^\"])*)?\""s
-numeric_in_list  = open_bracket numeric_value (comma spaces numeric_value)* closed_bracket
-text_in_list     = open_bracket text_value (comma spaces text_value)* closed_bracket
+numeric_in_list  = open_bracket numeric_value (spaces comma spaces numeric_value)* closed_bracket
+text_in_list     = open_bracket text_value (spaces comma spaces text_value)* closed_bracket
 
 # Formats
 iso_8601_date_format = ~r"(\d{4}-\d{2}-\d{2}(T\d{2}:\d{2}:\d{2}(\.\d{1,6})?)?(Z|([+-]\d{2}:\d{2}))?)(?=\s|\)|$)"
@@ -407,7 +407,7 @@ def visit_boolean_filter(self, node, children):
     def process_list(self, first, remaining):
         return [
             first,
-            *[item[2] for item in remaining],
+            *[item[3] for item in remaining],
         ]
 
     def visit_numeric_filter(self, node, children):
@@ -622,9 +622,7 @@ def visit_text_filter(self, node, children):
     def visit_text_in_filter(self, node, children):
         (negation, search_key, _, search_value) = children
         operator = "IN"
-        search_value = SearchValue(
-            self.process_list(search_value[1], [(_, _, val) for _, _, val in search_value[2]])
-        )
+        search_value = SearchValue(self.process_list(search_value[1], search_value[2]))
 
         operator = self.handle_negation(negation, operator)
 
@@ -683,10 +681,7 @@ def visit_aggregate_key(self, node, children):
         return AggregateKey(self.key_mappings_lookup.get(key, key))
 
     def visit_function_args(self, node, children):
-        args = [children[0]]
-        args.extend(v[3] for v in children[1])
-
-        return args
+        return self.process_list(children[0], children[1])
 
     def visit_search_value(self, node, children):
         return SearchValue(children[0])

tests/sentry/api/test_event_search.py

@@ -799,6 +799,13 @@ def test_numeric_in_filter(self):
                 value=SearchValue(raw_value=[500, 501, 502]),
             )
         ]
+        assert parse_search_query("project_id:[500, 501 ,502]") == [
+            SearchFilter(
+                key=SearchKey(name="project_id"),
+                operator="IN",
+                value=SearchValue(raw_value=[500, 501, 502]),
+            ),
+        ]
         assert parse_search_query("project_id:[500,501,502] issue.id:[100]") == [
             SearchFilter(
                 key=SearchKey(name="project_id"),