Skip to content

Commit 6fa6eb1

Browse files
authored
fix(severity): Initialize unbounded variable (#68219)
fixes SENTRY-34RZ
1 parent d81b553 commit 6fa6eb1

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

src/sentry/event_manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,6 +1836,7 @@ def _create_group(project: Project, event: Event, **group_creation_kwargs: Any)
18361836
group_data.setdefault("metadata", {}).update(sdk_metadata_from_event(event))
18371837

18381838
# add severity to metadata for alert filtering
1839+
severity: Mapping[str, Any] = {}
18391840
try:
18401841
group_type = group_creation_kwargs.get("type", None)
18411842
severity = _get_severity_metadata_for_group(event, project.id, group_type)

tests/sentry/event_manager/test_priority.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,3 +134,15 @@ def test_killswitch_on(self, mock_get_severity_score: MagicMock):
134134
assert event.group.priority == PriorityLevel.HIGH
135135
assert event.group.get_event_metadata()["initial_priority"] == PriorityLevel.HIGH
136136
assert mock_get_severity_score.call_count == 1
137+
138+
@patch("sentry.event_manager._get_severity_metadata_for_group", return_value={})
139+
def test_severity_error(self, mock_get_severity_metadata_for_group):
140+
event = EventManager(
141+
make_event(level=logging.WARNING, fingerprint=["def"], platform="python")
142+
).save(self.project.id)
143+
144+
assert event.group
145+
assert "severity" not in event.group.get_event_metadata()
146+
assert event.group.priority == PriorityLevel.MEDIUM
147+
assert event.group.get_event_metadata()["initial_priority"] == PriorityLevel.MEDIUM
148+
assert mock_get_severity_metadata_for_group.call_count == 1

0 commit comments

Comments
 (0)