Skip to content

Commit 975f8d7

Browse files
scttcperscttcper
authored
ref(issues): Remove project from group activity type (#92600)
1 parent 00f13de commit 975f8d7

File tree

10 files changed

+1
-72
lines changed

10 files changed

+1
-72
lines changed

‎static/app/components/events/interfaces/uptime/uptimeDataSection.spec.tsx‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,12 @@ describe('Uptime Data Section', function () {
2222
data: {},
2323
id: '2',
2424
dateCreated: '2024-06-21T20:36:51.884284Z',
25-
project,
2625
type: GroupActivityType.SET_RESOLVED,
2726
},
2827
{
2928
data: {},
3029
id: '1',
3130
dateCreated: '2024-06-20T20:36:51.884284Z',
32-
project,
3331
type: GroupActivityType.FIRST_SEEN,
3432
},
3533
];
@@ -67,28 +65,24 @@ describe('Uptime Data Section', function () {
6765
data: {},
6866
id: '4',
6967
dateCreated: '2024-06-22T22:36:51.884284Z',
70-
project,
7168
type: GroupActivityType.SET_RESOLVED,
7269
},
7370
{
7471
data: {},
7572
id: '3',
7673
dateCreated: '2024-06-22T20:36:51.884284Z',
77-
project,
7874
type: GroupActivityType.SET_REGRESSION,
7975
},
8076
{
8177
data: {},
8278
id: '2',
8379
dateCreated: '2024-06-21T20:36:51.884284Z',
84-
project,
8580
type: GroupActivityType.SET_RESOLVED,
8681
},
8782
{
8883
data: {},
8984
id: '1',
9085
dateCreated: '2024-06-20T20:36:51.884284Z',
91-
project,
9286
type: GroupActivityType.FIRST_SEEN,
9387
},
9488
];

‎static/app/components/feedback/feedbackItem/feedbackActivitySection.tsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,11 @@ function FeedbackActivitySection(props: Props) {
8888
data: n,
8989
type: GroupActivityType.NOTE,
9090
dateCreated: new Date().toISOString(),
91-
project: feedbackItem.project,
9291
user: me,
9392
};
9493
mutators.handleCreate(n, [newActivity, ...feedbackItem.activity], createOptions);
9594
},
96-
[createOptions, feedbackItem.activity, mutators, feedbackItem.project]
95+
[createOptions, feedbackItem.activity, mutators]
9796
);
9897

9998
const handleUpdate = useCallback(

‎static/app/components/resolutionBox.spec.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ describe('ResolutionBox', function () {
102102
current_release_version: currentReleaseVersion,
103103
},
104104
dateCreated: new Date().toISOString(),
105-
project,
106105
},
107106
]}
108107
/>

‎static/app/stores/groupStore.spec.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,6 @@ describe('GroupStore', function () {
251251
id: '1',
252252
type: GroupActivityType.NOTE,
253253
dateCreated: '',
254-
project: ProjectFixture(),
255254
data: {text: 'Orginal Text'},
256255
},
257256
],

‎static/app/types/group.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,6 @@ export enum GroupActivityType {
466466
interface GroupActivityBase {
467467
dateCreated: string;
468468
id: string;
469-
project: Project;
470469
assignee?: string;
471470
issue?: Group;
472471
user?: null | User;

‎static/app/views/issueDetails/groupActivity.spec.tsx‎

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ describe('GroupActivity', function () {
5959
data: {text: 'Test Note'},
6060
dateCreated: '2020-01-01T00:00:00',
6161
user: UserFixture(),
62-
project,
6362
},
6463
],
6564
project,
@@ -98,7 +97,6 @@ describe('GroupActivity', function () {
9897
type: GroupActivityType.MARK_REVIEWED,
9998
id: 'reviewed-1',
10099
dateCreated: '',
101-
project: ProjectFixture(),
102100
data: {},
103101
user,
104102
},
@@ -115,7 +113,6 @@ describe('GroupActivity', function () {
115113
activity: [
116114
{
117115
dateCreated: '',
118-
project: ProjectFixture(),
119116
type: GroupActivityType.SET_RESOLVED_IN_PULL_REQUEST,
120117
id: 'pr-1',
121118
data: {
@@ -149,7 +146,6 @@ describe('GroupActivity', function () {
149146
user,
150147
dateCreated: '2021-10-01T15:31:38.950115Z',
151148
id: '117',
152-
project: ProjectFixture(),
153149
type: GroupActivityType.ASSIGNED,
154150
},
155151
],
@@ -171,7 +167,6 @@ describe('GroupActivity', function () {
171167
rule: 'path:something/*.py #workflow',
172168
user: UserFixture(),
173169
},
174-
project: ProjectFixture(),
175170
dateCreated: '2021-10-01T15:31:38.950115Z',
176171
id: '117',
177172
type: GroupActivityType.ASSIGNED,
@@ -196,7 +191,6 @@ describe('GroupActivity', function () {
196191
integration: 'slack',
197192
user: UserFixture(),
198193
},
199-
project: ProjectFixture(),
200194
dateCreated: '2021-10-01T15:31:38.950115Z',
201195
id: '117',
202196
type: GroupActivityType.ASSIGNED,
@@ -220,7 +214,6 @@ describe('GroupActivity', function () {
220214
integration: 'suspectCommitter',
221215
user: UserFixture(),
222216
},
223-
project: ProjectFixture(),
224217
dateCreated: '1999-10-01T15:31:38.950115Z',
225218
id: '117',
226219
type: GroupActivityType.ASSIGNED,
@@ -247,7 +240,6 @@ describe('GroupActivity', function () {
247240
integration: 'lottery',
248241
user: UserFixture(),
249242
},
250-
project: ProjectFixture(),
251243
dateCreated: '1999-10-01T15:31:38.950115Z',
252244
id: '117',
253245
type: GroupActivityType.ASSIGNED,
@@ -269,7 +261,6 @@ describe('GroupActivity', function () {
269261
{
270262
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
271263
id: '123',
272-
project: ProjectFixture(),
273264
dateCreated: '',
274265
data: {
275266
commit: {
@@ -296,7 +287,6 @@ describe('GroupActivity', function () {
296287
{
297288
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
298289
id: '123',
299-
project: ProjectFixture(),
300290
dateCreated: '',
301291
data: {
302292
commit: {
@@ -329,7 +319,6 @@ describe('GroupActivity', function () {
329319
{
330320
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
331321
id: '123',
332-
project: ProjectFixture(),
333322
dateCreated: '',
334323
data: {
335324
commit: {
@@ -383,7 +372,6 @@ describe('GroupActivity', function () {
383372
id: '123',
384373
user: null,
385374
type: GroupActivityType.ASSIGNED,
386-
project: ProjectFixture(),
387375
data: {
388376
assignee: team.id,
389377
assigneeType: 'team',
@@ -438,7 +426,6 @@ describe('GroupActivity', function () {
438426
{
439427
id: '123',
440428
type: GroupActivityType.SET_IGNORED,
441-
project: ProjectFixture(),
442429
data: {
443430
ignoreUntilEscalating: true,
444431
},
@@ -457,7 +444,6 @@ describe('GroupActivity', function () {
457444
{
458445
id: '123',
459446
type: GroupActivityType.SET_UNRESOLVED,
460-
project: ProjectFixture(),
461447
data: {
462448
forecast: 200,
463449
},
@@ -467,7 +453,6 @@ describe('GroupActivity', function () {
467453
{
468454
id: '124',
469455
type: GroupActivityType.SET_ESCALATING,
470-
project: ProjectFixture(),
471456
data: {
472457
forecast: 400,
473458
},
@@ -491,7 +476,6 @@ describe('GroupActivity', function () {
491476
{
492477
id: '123',
493478
type: GroupActivityType.SET_UNRESOLVED,
494-
project: ProjectFixture(),
495479
data: {
496480
forecast: 1,
497481
},
@@ -512,7 +496,6 @@ describe('GroupActivity', function () {
512496
{
513497
id: '123',
514498
type: GroupActivityType.SET_UNRESOLVED,
515-
project: ProjectFixture(),
516499
data: {
517500
integration_id: '1',
518501
provider_key: 'jira',
@@ -533,7 +516,6 @@ describe('GroupActivity', function () {
533516
{
534517
id: '123',
535518
type: GroupActivityType.SET_RESOLVED,
536-
project: ProjectFixture(),
537519
data: {
538520
integration_id: '1',
539521
provider_key: 'jira',
@@ -554,7 +536,6 @@ describe('GroupActivity', function () {
554536
{
555537
id: '123',
556538
type: GroupActivityType.SET_ESCALATING,
557-
project: ProjectFixture(),
558539
data: {
559540
expired_snooze: {
560541
count: 400,
@@ -580,7 +561,6 @@ describe('GroupActivity', function () {
580561
{
581562
id: '123',
582563
type: GroupActivityType.SET_ESCALATING,
583-
project: ProjectFixture(),
584564
data: {
585565
expired_snooze: {
586566
user_count: 1,
@@ -607,7 +587,6 @@ describe('GroupActivity', function () {
607587
{
608588
id: '123',
609589
type: GroupActivityType.SET_ESCALATING,
610-
project: ProjectFixture(),
611590
data: {
612591
expired_snooze: {
613592
until: date,
@@ -633,7 +612,6 @@ describe('GroupActivity', function () {
633612
{
634613
id: '123',
635614
type: GroupActivityType.SET_IGNORED,
636-
project: ProjectFixture(),
637615
data: {},
638616
user: UserFixture(),
639617
dateCreated,
@@ -650,7 +628,6 @@ describe('GroupActivity', function () {
650628
{
651629
id: '123',
652630
type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
653-
project: ProjectFixture(),
654631
data: {
655632
version: '[email protected]',
656633
},
@@ -671,7 +648,6 @@ describe('GroupActivity', function () {
671648
{
672649
id: '123',
673650
type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
674-
project: ProjectFixture(),
675651
data: {
676652
current_release_version: '[email protected]',
677653
},
@@ -693,7 +669,6 @@ describe('GroupActivity', function () {
693669
{
694670
id: '123',
695671
type: GroupActivityType.SET_REGRESSION,
696-
project: ProjectFixture(),
697672
data: {},
698673
dateCreated,
699674
},
@@ -709,7 +684,6 @@ describe('GroupActivity', function () {
709684
{
710685
id: '123',
711686
type: GroupActivityType.SET_REGRESSION,
712-
project: ProjectFixture(),
713687
data: {
714688
version: '[email protected]',
715689
},
@@ -729,7 +703,6 @@ describe('GroupActivity', function () {
729703
{
730704
id: '123',
731705
type: GroupActivityType.SET_REGRESSION,
732-
project: ProjectFixture(),
733706
data: {
734707
version: '[email protected]',
735708
resolved_in_version: '[email protected]',
@@ -754,7 +727,6 @@ describe('GroupActivity', function () {
754727
{
755728
id: '123',
756729
type: GroupActivityType.SET_REGRESSION,
757-
project: ProjectFixture(),
758730
data: {
759731
version: 'frontend@abc1',
760732
resolved_in_version: 'frontend@abc2',
@@ -779,7 +751,6 @@ describe('GroupActivity', function () {
779751
{
780752
id: '123',
781753
type: GroupActivityType.SET_PRIORITY,
782-
project: ProjectFixture(),
783754
data: {
784755
priority: PriorityLevel.HIGH,
785756
reason: 'escalating',
@@ -800,7 +771,6 @@ describe('GroupActivity', function () {
800771
{
801772
id: '123',
802773
type: GroupActivityType.SET_PRIORITY,
803-
project: ProjectFixture(),
804774
data: {
805775
priority: PriorityLevel.LOW,
806776
reason: 'ongoing',
@@ -821,7 +791,6 @@ describe('GroupActivity', function () {
821791
{
822792
id: '123',
823793
type: GroupActivityType.DELETED_ATTACHMENT,
824-
project: ProjectFixture(),
825794
data: {},
826795
dateCreated,
827796
user: UserFixture(),

‎static/app/views/issueDetails/streamline/occurrenceSummary.spec.tsx‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {EventFixture} from 'sentry-fixture/event';
22
import {GroupFixture} from 'sentry-fixture/group';
33
import {OrganizationFixture} from 'sentry-fixture/organization';
4-
import {ProjectFixture} from 'sentry-fixture/project';
54

65
import {render, screen} from 'sentry-test/reactTestingLibrary';
76
import {resetMockDate, setMockDate} from 'sentry-test/utils';
@@ -16,7 +15,6 @@ import {OccurrenceSummary} from 'sentry/views/issueDetails/streamline/occurrence
1615

1716
describe('OccurrenceSummary', () => {
1817
const organization = OrganizationFixture();
19-
const project = ProjectFixture();
2018

2119
afterEach(() => {
2220
resetMockDate();
@@ -41,14 +39,12 @@ describe('OccurrenceSummary', () => {
4139
type: GroupActivityType.SET_RESOLVED,
4240
dateCreated: '2025-01-02T11:00:00Z',
4341
data: {},
44-
project,
4542
id: '2',
4643
},
4744
{
4845
type: GroupActivityType.FIRST_SEEN,
4946
dateCreated: '2025-01-01T11:00:00Z',
5047
data: {},
51-
project,
5248
id: '1',
5349
},
5450
],

‎static/app/views/issueDetails/streamline/sidebar/activitySection.spec.tsx‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ describe('StreamlinedActivitySection', function () {
3535
data: {text: 'Test Note'},
3636
dateCreated: '2020-01-01T00:00:00',
3737
user,
38-
project,
3938
},
4039
],
4140
project,
@@ -144,7 +143,6 @@ describe('StreamlinedActivitySection', function () {
144143
data: {text: 'Group Test'},
145144
dateCreated: '2020-01-01T00:00:00',
146145
user,
147-
project,
148146
},
149147
],
150148
project,
@@ -191,7 +189,6 @@ describe('StreamlinedActivitySection', function () {
191189
data: {text: 'Test Note'},
192190
dateCreated: '2020-01-01T00:00:00',
193191
user: UserFixture({id: '2'}),
194-
project,
195192
},
196193
],
197194
project,
@@ -276,7 +273,6 @@ describe('StreamlinedActivitySection', function () {
276273
data: {text: 'Resolved'},
277274
dateCreated: '2020-01-01T00:00:00',
278275
user,
279-
project,
280276
});
281277

282278
const updatedActivityGroup = GroupFixture({

0 commit comments

Comments
 (0)