Advanced SQL Analytics Framework #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vulnerability (#94942) * disable sql expressions remove duckdb ref * Run `make update-workspace` --------- Co-authored-by: Scott Lepper <[email protected]>
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 9
Replicated from ai-code-review-evaluation/grafana-cursor#9
Note
Replaces external duck DB usage with an internal stubbed SQL DB and disables SQL expressions behind a feature flag; cleans up related dependencies.
pkg/expr/sql/db.gowith an internal in-memoryDB(stub methods:TablesList,RunCommands,QueryFramesInto).pkg/expr/sql/parser.goto useNewInMemoryDB()instead of external duck DB; removes duck import.pkg/expr/sql_command.goto execute queries via internalsql.NewInMemoryDB().pkg/expr/reader.goforQueryTypeSQL; when disabled, returnssqlExpressions is not implemented.github.com/scottlepp/go-duckand related transitive entries; prunes other unused indirect deps ingo.mod/go.sum.Written by Cursor Bugbot for commit ea71201. Configure here.