-
Notifications
You must be signed in to change notification settings - Fork 47
Expand file tree
/
Copy pathtest_worker.py
More file actions
322 lines (274 loc) · 11.8 KB
/
test_worker.py
File metadata and controls
322 lines (274 loc) · 11.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
import asyncio
from unittest.mock import AsyncMock, Mock
import pytest
from aiperf.common.config.service_config import ServiceConfig
from aiperf.common.config.user_config import UserConfig
from aiperf.common.enums import CreditPhase
from aiperf.common.models import (
Conversation,
ParsedResponse,
ReasoningResponseData,
RequestRecord,
SSEMessage,
TextResponseData,
)
from aiperf.credit.structs import Credit, CreditContext
from aiperf.workers.worker import Worker
from tests.harness.fake_communication import FakeCommunication as FakeCommunication
from tests.harness.fake_service_manager import FakeServiceManager as FakeServiceManager
from tests.harness.fake_tokenizer import FakeTokenizer
from tests.harness.fake_transport import FakeTransport as FakeTransport
@pytest.fixture
async def mock_worker(
user_config: UserConfig,
service_config: ServiceConfig,
fake_tokenizer: FakeTokenizer,
skip_service_registration,
):
"""Create a fully initialized and started MockWorker (no SystemController needed)."""
worker = Worker(
service_config=service_config,
user_config=user_config,
service_id="mock-service-id",
)
await worker.initialize()
await worker.start()
yield worker
await worker.stop()
@pytest.mark.asyncio
class TestWorker:
async def test_process_response(
self, monkeypatch, mock_worker, sample_request_record
):
"""Ensure process_response extracts text correctly from RequestRecord."""
mock_parsed_response = ParsedResponse(
perf_ns=0,
data=TextResponseData(text="Hello, world!"),
)
mock_endpoint = Mock()
mock_endpoint.extract_response_data = Mock(return_value=[mock_parsed_response])
monkeypatch.setattr(mock_worker.inference_client, "endpoint", mock_endpoint)
turn = await mock_worker._process_response(sample_request_record)
assert turn.texts[0].contents == ["Hello, world!"]
async def test_process_response_empty(
self, monkeypatch, mock_worker, sample_request_record
):
"""Ensure process_response handles empty responses correctly."""
mock_parsed_response = ParsedResponse(
perf_ns=0,
data=TextResponseData(text=""),
)
mock_endpoint = Mock()
mock_endpoint.extract_response_data = Mock(return_value=[mock_parsed_response])
monkeypatch.setattr(mock_worker.inference_client, "endpoint", mock_endpoint)
turn = await mock_worker._process_response(sample_request_record)
assert turn is None
async def test_process_response_reasoning_extracts_content(
self, monkeypatch, mock_worker
):
"""Ensure process_response extracts content from reasoning responses."""
mock_parsed_response = ParsedResponse(
perf_ns=0,
data=ReasoningResponseData(
reasoning="Let me think...",
content="The answer is 42.",
),
)
mock_endpoint = Mock()
mock_endpoint.extract_response_data = Mock(return_value=[mock_parsed_response])
monkeypatch.setattr(mock_worker.inference_client, "endpoint", mock_endpoint)
turn = await mock_worker._process_response(RequestRecord())
assert turn.texts[0].contents == ["The answer is 42."]
async def test_process_response_reasoning_only_returns_none(
self, monkeypatch, mock_worker
):
"""Ensure process_response returns None for reasoning-only responses (no content)."""
mock_parsed_response = ParsedResponse(
perf_ns=0,
data=ReasoningResponseData(
reasoning="Let me think about this...",
content=None,
),
)
mock_endpoint = Mock()
mock_endpoint.extract_response_data = Mock(return_value=[mock_parsed_response])
monkeypatch.setattr(mock_worker.inference_client, "endpoint", mock_endpoint)
turn = await mock_worker._process_response(RequestRecord())
assert turn is None
async def test_process_response_mixed_reasoning_and_text_combines_content(
self, monkeypatch, mock_worker
):
"""Ensure process_response combines text and reasoning content."""
mock_parsed_responses = [
ParsedResponse(
perf_ns=0,
data=TextResponseData(text="Hello"),
),
ParsedResponse(
perf_ns=1,
data=ReasoningResponseData(
reasoning="Thinking...",
content="World",
),
),
]
mock_endpoint = Mock()
mock_endpoint.extract_response_data = Mock(return_value=mock_parsed_responses)
monkeypatch.setattr(mock_worker.inference_client, "endpoint", mock_endpoint)
turn = await mock_worker._process_response(RequestRecord())
assert turn.texts[0].contents == ["HelloWorld"]
# --- FirstToken Callback Test Helpers ---
def create_first_token_callback(worker: Worker):
"""Create a first token callback that mirrors Worker implementation.
This callback uses endpoint.parse_response to check if an SSE message
contains meaningful content.
Returns:
Async callback function (ttft_ns, message) -> bool
"""
async def first_token_callback(ttft_ns: int, message: SSEMessage) -> bool:
parsed = worker.inference_client.endpoint.parse_response(message)
return parsed is not None and parsed.data is not None
return first_token_callback
def setup_mock_endpoint(worker: Worker, monkeypatch, parse_response_return):
"""Setup mock endpoint with specified parse_response return value.
Args:
worker: MockWorker instance
monkeypatch: pytest monkeypatch fixture
parse_response_return: Return value or side_effect for parse_response
"""
mock_endpoint = Mock()
if isinstance(parse_response_return, list):
mock_endpoint.parse_response = Mock(side_effect=parse_response_return)
else:
mock_endpoint.parse_response = Mock(return_value=parse_response_return)
mock_endpoint.extract_response_data = Mock() # Should NOT be called
monkeypatch.setattr(worker.inference_client, "endpoint", mock_endpoint)
return mock_endpoint
@pytest.mark.asyncio
class TestWorkerFirstTokenCallback:
"""Test suite for Worker's first_token_callback logic."""
@pytest.mark.parametrize(
"parse_return,expected_result,description",
[
# Meaningful content - should return True
pytest.param(
ParsedResponse(
perf_ns=100_000_000, data=TextResponseData(text="Hello")
),
True,
"meaningful text content",
id="meaningful_content",
),
# None response - should return False
pytest.param(
None,
False,
"parse_response returns None",
id="none_response",
),
# ParsedResponse with data=None (usage only) - should return False
pytest.param(
ParsedResponse(
perf_ns=100_000_000,
data=None,
usage={"prompt_tokens": 10, "completion_tokens": 0},
),
False,
"usage-only response with data=None",
id="none_data",
),
],
)
async def test_callback_return_value(
self, monkeypatch, mock_worker, parse_return, expected_result, description
):
"""Test callback returns correct bool based on parse_response result."""
setup_mock_endpoint(mock_worker, monkeypatch, parse_return)
callback = create_first_token_callback(mock_worker)
test_message = SSEMessage(perf_ns=100_000_000)
result = await callback(50_000_000, test_message)
assert result is expected_result, f"Failed for: {description}"
async def test_callback_finds_first_meaningful_content_after_junk(
self, monkeypatch, mock_worker
):
"""Test callback correctly identifies first meaningful content after junk messages."""
parse_returns = [
None, # First: junk
ParsedResponse(perf_ns=200_000_000, data=None), # Second: usage only
ParsedResponse( # Third: actual content
perf_ns=300_000_000,
data=TextResponseData(text="Finally some content!"),
),
]
setup_mock_endpoint(mock_worker, monkeypatch, parse_returns)
callback = create_first_token_callback(mock_worker)
messages = [SSEMessage(perf_ns=i * 100_000_000) for i in range(1, 4)]
results = [await callback(msg.perf_ns, msg) for msg in messages]
assert results == [False, False, True]
# --- Fixture for CreditContext ---
@pytest.fixture
def sample_credit_context() -> CreditContext:
"""Create a sample CreditContext for testing."""
return CreditContext(
credit=Credit(
id=1,
phase=CreditPhase.PROFILING,
conversation_id="test-conv-123",
x_correlation_id="test-correlation-id",
turn_index=0,
num_turns=1,
issued_at_ns=1000000,
),
drop_perf_ns=2000000,
)
# --- RetrieveConversation Tests ---
@pytest.mark.asyncio
class TestRetrieveConversation:
"""Test suite for Worker's _retrieve_conversation method."""
async def test_returns_from_dataset_client_when_available(
self, mock_worker, sample_credit_context
):
"""When _dataset_client is set, should return conversation from it."""
expected_conversation = Conversation(session_id="test-conv-123", turns=[])
mock_client = AsyncMock()
mock_client.get_conversation = AsyncMock(return_value=expected_conversation)
mock_worker._dataset_client = mock_client
result = await mock_worker._retrieve_conversation(
conversation_id="test-conv-123",
credit_context=sample_credit_context,
)
assert result == expected_conversation
mock_client.get_conversation.assert_called_once_with("test-conv-123")
async def test_raises_cancelled_error_when_stop_requested_and_no_client(
self, mock_worker, sample_credit_context
):
"""When _dataset_client is None and stop_requested, should raise CancelledError."""
mock_worker._dataset_client = None
mock_worker.stop_requested = True
with pytest.raises(asyncio.CancelledError, match="Stop requested"):
await mock_worker._retrieve_conversation(
conversation_id="test-conv-123",
credit_context=sample_credit_context,
)
async def test_falls_back_to_dataset_manager_when_no_client_and_not_stopping(
self, monkeypatch, mock_worker, sample_credit_context
):
"""When _dataset_client is None and not stopping, should request client metadata from DatasetManager."""
mock_worker._dataset_client = None
expected_conversation = Conversation(session_id="test-conv-123", turns=[])
async def mock_request_client(self_worker):
mock_client = AsyncMock()
mock_client.get_conversation = AsyncMock(return_value=expected_conversation)
self_worker._dataset_client = mock_client
monkeypatch.setattr(
mock_worker,
"_request_dataset_client_from_dataset_manager",
lambda: mock_request_client(mock_worker),
)
result = await mock_worker._retrieve_conversation(
conversation_id="test-conv-123",
credit_context=sample_credit_context,
)
assert result == expected_conversation