fix: Don't set min_tokens when ignore_eos is true (#4908)

dagil-nvidia · jthomson04 · web-flow · commit 15f1a73b375e · 2025-12-11T17:12:17.000-05:00
Signed-off-by: jthomson04 &lt;jwillthomson19@gmail.com&gt;
Signed-off-by: Dan Gil &lt;dagil@nvidia.com&gt;
Co-authored-by: jthomson04 &lt;jwillthomson19@gmail.com&gt;
diff --git a/lib/llm/src/protocols/common.rs b/lib/llm/src/protocols/common.rs
@@ -254,7 +254,6 @@ pub struct StopConditions {
 impl StopConditions {
     pub fn apply_ignore_eos(&mut self) {
         if self.ignore_eos.unwrap_or(false) {
-            self.min_tokens = self.max_tokens;
             self.stop = None;
             self.stop_token_ids_hidden = None;
         }

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,6 @@ pub struct StopConditions {`
`254`	`254`	`impl StopConditions {`
`255`	`255`	`pub fn apply_ignore_eos(&mut self) {`
`256`	`256`	`if self.ignore_eos.unwrap_or(false) {`
`257`		`- self.min_tokens = self.max_tokens;`
`258`	`257`	`self.stop = None;`
`259`	`258`	`self.stop_token_ids_hidden = None;`
`260`	`259`	`}`