Skip to content

Commit e3ba40e

Browse files
ci: Fix frontend pod detection in deploy tests (#4054)
Signed-off-by: Dillon Cullinan <[email protected]>
1 parent dadf0e2 commit e3ba40e

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.github/workflows/container-validation-backends.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ jobs:
344344
deploy-operator:
345345
runs-on: cpu-amd-m5-2xlarge
346346
if: needs.changed-files.outputs.has_code_changes == 'true'
347-
needs: [changed-files, operator]
347+
needs: [changed-files, operator, vllm, sglang, trtllm]
348348
env:
349349
DYNAMO_INGRESS_SUFFIX: dev.aire.nvidia.com
350350
outputs:
@@ -455,6 +455,7 @@ jobs:
455455
export FRAMEWORK_RUNTIME_IMAGE="${{ secrets.AZURE_ACR_HOSTNAME }}/ai-dynamo/dynamo:${{ github.sha }}-${FRAMEWORK}-amd64"
456456
export KUBE_NS=$NAMESPACE
457457
export GRAPH_NAME=$(yq e '.metadata.name' $DEPLOYMENT_FILE)
458+
echo "GRAPH_NAME=${GRAPH_NAME}" >> $GITHUB_ENV
458459
# Update the deployment file in-place
459460
yq -i '.spec.services.[].extraPodSpec.mainContainer.image = env(FRAMEWORK_RUNTIME_IMAGE)' $DEPLOYMENT_FILE
460461
@@ -479,7 +480,7 @@ jobs:
479480
echo ""
480481
481482
kubectl get all -n $KUBE_NS
482-
export FRONTEND_POD=$(kubectl get pods -n ${KUBE_NS} | grep "frontend" | sort -k1 | tail -n1 | awk '{print $1}')
483+
export FRONTEND_POD=$(kubectl get pods -n ${KUBE_NS} | grep ${GRAPH_NAME}-frontend | sort -k1 | tail -n1 | awk '{print $1}')
483484
export CONTAINER_PORT=$(kubectl get pod $FRONTEND_POD -n ${KUBE_NS} -o jsonpath='{.spec.containers[0].ports[?(@.name=="http")].containerPort}')
484485
echo "Container port is ${CONTAINER_PORT}"
485486
kubectl port-forward pod/$FRONTEND_POD 8000:${CONTAINER_PORT} -n ${KUBE_NS} &
@@ -547,7 +548,6 @@ jobs:
547548
timeout-minutes: 5
548549
env:
549550
NAMESPACE: ${{ needs.deploy-operator.outputs.NAMESPACE }}
550-
PROFILE: ${{ matrix.profile }}
551551
run: |
552552
set -x
553553
export KUBECONFIG=$(pwd)/.kubeconfig
@@ -557,8 +557,7 @@ jobs:
557557
kubectl get all
558558
559559
echo "Deleting DynamoGraphDeployments for this job in namespace $NAMESPACE..."
560-
PROFILE_SANITIZED="${PROFILE/_/-}"
561-
kubectl delete dynamographdeployments $FRAMEWORK-$PROFILE_SANITIZED -n $NAMESPACE || true
560+
kubectl delete dynamographdeployments ${GRAPH_NAME} -n $NAMESPACE || true
562561
563562
deploy-test-sglang:
564563
runs-on: cpu-amd-m5-2xlarge

0 commit comments

Comments
 (0)