Skip to content

Commit 236871b

Browse files
committed
formatting changes
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
1 parent 6af8c72 commit 236871b

File tree

8 files changed

+18
-16
lines changed

8 files changed

+18
-16
lines changed

operator/internal/controller/podcliqueset/components/podgang/podgang.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,14 @@ func getLabels(pcs *grovecorev1alpha1.PodCliqueSet) map[string]string {
161161
map[string]string{
162162
apicommon.LabelComponentKey: apicommon.LabelComponentNamePodGang,
163163
})
164-
164+
165165
// Add scheduler-backend label so Backend Controllers can identify which PodGang to handle
166166
// Check scheduler name from the first clique (all cliques should have same scheduler)
167167
schedulerName := ""
168168
if len(pcs.Spec.Template.Cliques) > 0 {
169169
schedulerName = pcs.Spec.Template.Cliques[0].Spec.PodSpec.SchedulerName
170170
}
171-
171+
172172
// Determine backend based on schedulerName
173173
if schedulerName == "" || schedulerName == "default-scheduler" {
174174
// Use Workload backend for default kube-scheduler
@@ -177,6 +177,6 @@ func getLabels(pcs *grovecorev1alpha1.PodCliqueSet) map[string]string {
177177
// Use KAI backend for custom schedulers
178178
labels[apicommon.LabelSchedulerBackend] = "kai"
179179
}
180-
180+
181181
return labels
182182
}

operator/internal/controller/podcliqueset/components/workload/workload.go

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ import (
3939
)
4040

4141
const (
42-
errCodeListWorkloads grovecorev1alpha1.ErrorCode = "ERR_LIST_WORKLOADS"
43-
errCodeDeleteWorkloads grovecorev1alpha1.ErrorCode = "ERR_DELETE_WORKLOADS"
44-
errCodeDeleteExcessWorkload grovecorev1alpha1.ErrorCode = "ERR_DELETE_EXCESS_WORKLOAD"
45-
errCodeListPods grovecorev1alpha1.ErrorCode = "ERR_LIST_PODS_FOR_PODCLIQUESET"
46-
errCodeListPodCliques grovecorev1alpha1.ErrorCode = "ERR_LIST_PODCLIQUES_FOR_PODCLIQUESET"
47-
errCodeListPodCliqueScalingGroup grovecorev1alpha1.ErrorCode = "ERR_LIST_PODCLIQUESCALINGGROUPS"
48-
errCodeComputeExistingWorkload grovecorev1alpha1.ErrorCode = "ERR_COMPUTE_EXISTING_WORKLOAD"
49-
errCodeSetControllerReference grovecorev1alpha1.ErrorCode = "ERR_SET_CONTROLLER_REFERENCE"
50-
errCodeCreateOrPatchWorkload grovecorev1alpha1.ErrorCode = "ERR_CREATE_OR_PATCH_WORKLOAD"
42+
errCodeListWorkloads grovecorev1alpha1.ErrorCode = "ERR_LIST_WORKLOADS"
43+
errCodeDeleteWorkloads grovecorev1alpha1.ErrorCode = "ERR_DELETE_WORKLOADS"
44+
errCodeDeleteExcessWorkload grovecorev1alpha1.ErrorCode = "ERR_DELETE_EXCESS_WORKLOAD"
45+
errCodeListPods grovecorev1alpha1.ErrorCode = "ERR_LIST_PODS_FOR_PODCLIQUESET"
46+
errCodeListPodCliques grovecorev1alpha1.ErrorCode = "ERR_LIST_PODCLIQUES_FOR_PODCLIQUESET"
47+
errCodeListPodCliqueScalingGroup grovecorev1alpha1.ErrorCode = "ERR_LIST_PODCLIQUESCALINGGROUPS"
48+
errCodeComputeExistingWorkload grovecorev1alpha1.ErrorCode = "ERR_COMPUTE_EXISTING_WORKLOAD"
49+
errCodeSetControllerReference grovecorev1alpha1.ErrorCode = "ERR_SET_CONTROLLER_REFERENCE"
50+
errCodeCreateOrPatchWorkload grovecorev1alpha1.ErrorCode = "ERR_CREATE_OR_PATCH_WORKLOAD"
5151
)
5252

5353
type _resource struct {
@@ -173,4 +173,3 @@ func getLabels(pcsName string) map[string]string {
173173
apicommon.LabelComponentKey: apicommon.LabelComponentNamePodGang,
174174
})
175175
}
176-

operator/internal/controller/podcliqueset/reconcilespec.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func getOrderedKindsForSync(pcs *grovecorev1alpha1.PodCliqueSet) []component.Kin
212212
component.KindPodClique,
213213
component.KindPodCliqueScalingGroup,
214214
}
215-
215+
216216
// NEW ARCHITECTURE: Always create PodGang as the unified intermediate representation
217217
// Backend Controllers will convert PodGang to scheduler-specific CRs (Workload/PodGroup)
218218
return append(baseKinds, component.KindPodGang)

operator/internal/controller/register.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,10 @@ import (
2323
"github.com/ai-dynamo/grove/operator/internal/controller/podcliqueset"
2424
"github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend"
2525
backendcontroller "github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend/controller"
26-
"github.com/go-logr/logr"
2726

27+
"github.com/go-logr/logr"
2828
ctrl "sigs.k8s.io/controller-runtime"
2929

30-
// Import backend packages to trigger their init() functions which register factories
3130
_ "github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend/kai"
3231
_ "github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend/workload"
3332
)

operator/internal/controller/scheduler/backend/controller/manager.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"fmt"
2121

2222
"github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend"
23+
2324
"github.com/go-logr/logr"
2425
ctrl "sigs.k8s.io/controller-runtime"
2526
)

operator/internal/controller/scheduler/backend/controller/reconciler.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"fmt"
2222

2323
"github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend"
24+
2425
groveschedulerv1alpha1 "github.com/ai-dynamo/grove/scheduler/api/core/v1alpha1"
2526
"github.com/go-logr/logr"
2627
"k8s.io/apimachinery/pkg/runtime"

operator/internal/controller/scheduler/backend/kai/backend.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
"github.com/ai-dynamo/grove/operator/api/common"
2424
grovecorev1alpha1 "github.com/ai-dynamo/grove/operator/api/core/v1alpha1"
2525
"github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend"
26+
2627
groveschedulerv1alpha1 "github.com/ai-dynamo/grove/scheduler/api/core/v1alpha1"
2728
"github.com/go-logr/logr"
2829
corev1 "k8s.io/api/core/v1"

operator/internal/controller/scheduler/backend/workload/backend.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
"github.com/ai-dynamo/grove/operator/api/common"
2424
grovecorev1alpha1 "github.com/ai-dynamo/grove/operator/api/core/v1alpha1"
2525
"github.com/ai-dynamo/grove/operator/internal/controller/scheduler/backend"
26+
2627
groveschedulerv1alpha1 "github.com/ai-dynamo/grove/scheduler/api/core/v1alpha1"
2728
"github.com/go-logr/logr"
2829
corev1 "k8s.io/api/core/v1"

0 commit comments

Comments
 (0)