RUST: Index/IndexMut and get/get_mut for RegDescList and XferDescList #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Leksikov <[email protected]>
Signed-off-by: Evgeny Leksikov <[email protected]>
|
👋 Hi evgeny-leksikov! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
evgeny-leksikov
requested review from
gleon99,
mkhazraee and
roiedanino
as code owners
Contributor
Author
|
/build |
roiedanino
reviewed
Nov 9, 2025
Comment on lines
+1836
to
+1840
| { | ||
| let desc = reg_list.get_mut(0).unwrap(); | ||
| desc.addr = 0x5000; | ||
| desc.len = 0x500; | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe we can validate that the dirty bit was set?
Contributor
Author
There was a problem hiding this comment.
The dirty bit is private. I added testing of sync manager here: #1006
roiedanino
approved these changes
Nov 9, 2025
Contributor
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
In continue of #828