PLUGINS/UCX: Moved src/utils/ucx/* to src/plugins/ucx. #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Akhmetshin <[email protected]>
rakhmets
requested review from
a team,
brminich,
gleon99 and
yosefe
as code owners
|
👋 Hi rakhmets! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Raul Akhmetshin <[email protected]>
rakhmets
force-pushed
the
topic/mv-utils-ucx
branch
from
a6c5ef1 to
8d00458
Compare
rakhmets
commented
Nov 7, 2025
| void | ||
| config::modify (std::string_view key, std::string_view value) const { | ||
| const char *env_val = std::getenv (absl::StrFormat ("UCX_%s", key.data()).c_str()); | ||
| config::modify(std::string_view key, std::string_view value) const { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it is impossible to avoid formatting changes for the moved files.
Contributor
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moved
src/utils/ucx/*tosrc/plugins/ucx.Why?
All code related to the
UCXplugin can be moved tosrc/plugins/ucx, as theUCX_MOplugin has been removed: #898.