plugins/posix: AIO resubmission fixed #1020
Open
+11
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-nayshtut
requested review from
barneuman,
etoledano,
vvenkates27 and
w1ldptr
as code owners
|
👋 Hi anton-nayshtut! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
The Linux AIO plugin wasn’t capable of re-submission; it required IO to be re-prepared prior to re-submission. It also used to return NIXL_IN_PROG for the next submit(), and NIXL_SUCCESS for checkCompleted(), making the upper layer think that the re-submission succeeded. This, in turn, caused incorrect throughput-related calculations. This patch fixes the bug. Signed-off-by: Anton Nayshtut <[email protected]>
anton-nayshtut
force-pushed
the
antonn/linux_aio_queue_resubmission_fix
branch
from
17935c4 to
27d816a
Compare
aranadive
reviewed
Nov 13, 2025
| } | ||
|
|
||
| if (num_ios_to_complete) { | ||
| NIXL_ERROR << "previous submit is not completed"; |
Contributor
There was a problem hiding this comment.
Suggested change
| NIXL_ERROR << "previous submit is not completed"; | |
| NIXL_ERROR << "previously submitted IO is not yet complete"; |
aranadive
reviewed
Nov 13, 2025
| struct iocb *io = events[i].obj; | ||
| size_t idx = (size_t)io->data; | ||
|
|
||
| ios_to_submit[idx] = nullptr; // Mark as completed |
Contributor
There was a problem hiding this comment.
Do you still need to set this then in prepIO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux AIO plugin wasn’t capable of re-submission; it required IO to be re-prepared prior to re-submission.
It also used to return
NIXL_IN_PROGfor the nextsubmit(), andNIXL_SUCCESSforcheckCompleted(), making the upper layer think that the re-submission succeeded. This, in turn, caused incorrect throughput-related calculations.This patch fixes the bug.