log: replace std::cout with NIXL_INFO in nixlDescList::print #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shijie Ma <[email protected]>
|
👋 Hi matumu! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
brminich
requested changes
Nov 14, 2025
| template <class T> | ||
| void nixlDescList<T>::print() const { | ||
| std::cout << "DescList of mem type " << type << std::endl; | ||
| NIXL_INFO << "DescList of mem type " << type; |
Contributor
There was a problem hiding this comment.
std::count here is on purpose - because we expect that print() method would always print without the need to set NIXL_LOG_LEVEL=info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
replace std::cout with NIXL_INFO in nixlDescList::print