BUILD: Fix UCX GPU device API detection #990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
Signed-off-by: Michal Shalev <[email protected]>
michal-shalev
force-pushed
the
fix-device-api-build
branch
from
e915948 to
f1aefa4
Compare
Contributor
Author
|
/build |
aranadive
previously approved these changes
Nov 4, 2025
Contributor
|
/build |
brminich
reviewed
Nov 12, 2025
meson.build
Outdated
Comment on lines
125
to
126
| nvcc_cmd = find_program('nvcc', required: false) | ||
| if nvcc_cmd.found() |
Contributor
There was a problem hiding this comment.
why do we still need it?
on line 107 we use the same version comparision without nvcc_cmd
Signed-off-by: Michal Shalev <[email protected]>
brminich
reviewed
Nov 12, 2025
meson.build
Outdated
Comment on lines
124
to
130
| # DOCA GPUNETIO | ||
| if nvcc.version().version_compare('>=12.8') and nvcc.version().version_compare('<13.0') | ||
| doca_gpunetio_dep = dependency('doca-gpunetio', required : false) | ||
| else | ||
| warning('CUDA version = ' + nvcc.version() + ', GPUNETIO plugin will be disabled') | ||
| doca_gpunetio_dep = disabler() | ||
| endif |
Contributor
There was a problem hiding this comment.
can we now delete it since it looks exactly the same as lines 107-112
Signed-off-by: Michal Shalev <[email protected]>
brminich
approved these changes
Nov 12, 2025
Contributor
Author
|
/build |
ovidiusm
approved these changes
Nov 13, 2025
Contributor
|
failure looks related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes UCX GPU Device API detection.
Why?
The UCX GPU-side compilation check was failing because:
doca_gpunetio_dev_verbs_qp.cuh), but the compilation check wasn't passing the DOCA dependencyWithout these fixes,
HAVE_UCX_GPU_DEVICE_APIwas not defined even when all requirements were met.How?
nvcc.version()instead ofnvcc_cmd.version()for reliable version detectiondoca_gpunetio_depto the UCX GPU-side compilation check dependencies