-
Notifications
You must be signed in to change notification settings - Fork 183
CI: Update cuda ver for GPU tests to 13 #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alexey-Rivkin
wants to merge
20
commits into
ai-dynamo:main
Choose a base branch
from
Alexey-Rivkin:cuda_update-gpu_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+27
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi Alexey-Rivkin! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
3452af5 to
a9dbdd0
Compare
Contributor
Author
|
/build |
a9dbdd0 to
1b41982
Compare
1b41982 to
f18ef86
Compare
Contributor
Author
|
/build |
ovidiusm
reviewed
Nov 13, 2025
Some tests (e.g. gpunetio) only run on specific CUDA ver. Adding both CUDA 12 and 13 improves coverage. Signed-off-by: Alexey Rivkin <[email protected]>
Contributor
Author
|
/build |
ovidiusm
reviewed
Nov 13, 2025
| - **Operating System**: Ubuntu 22.04/24.04 LTS (recommended) or RHEL-based | ||
| - **Docker**: Version 20.10+ (for container builds) | ||
| - **Git**: For source code management | ||
| - **CUDA Toolkit**: 12.8+ (for GPU features) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to document 13.0 as a hard requirement already @aranadive WDYT?
ovidiusm
approved these changes
Nov 13, 2025
dpressle
approved these changes
Nov 13, 2025
brminich
approved these changes
Nov 13, 2025
Contributor
|
/build |
yexiang-aws
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade CI to CUDA 13.0 for GPU testing.
Why?
Align with newer CUDA releases for CUDA 13.x support.
How?
25.10-cuda13.0, Ubuntu 22.04 tonvidia/cuda:13.0.1meson.build)nixl-cu12tonixl-cu13Also fix POSIX shell compatibility in
common.shto prevent OOM.