fix: 404 intead of 401/un authorised for non existant api

Author: abose

src/server.js

@@ -26,7 +26,16 @@ const server = fastify({logger: true});
 /* Adding an authentication hook to the server. A hook is a function that is called when a request is made to
 the server. */
 server.addHook('onRequest', (request, reply, done) => {
-    if (!isAuthenticated(request)) {
+    const routeExists = server.hasRoute({
+        url: request.raw.url,
+        method: request.raw.method
+        // constraints: { version: '1.0.0' } specify this if you are doing something custom
+    });
+
+    if (!routeExists) {
+        reply.code(HTTP_STATUS_CODES.NOT_FOUND);
+        done(new Error('Not Found'));
+    } else if (!isAuthenticated(request)) {
         reply.code(HTTP_STATUS_CODES.UNAUTHORIZED);
         done(new Error('Wrong key'));
     } else {

test/integration/hello.spec.js

@@ -37,4 +37,14 @@ describe('Integration Tests for hello api', function () {
             "message": "Wrong key",
             "statusCode": 401});
     });
+
+    it('should reply 404 if route doesnt exist', async function () {
+        let output = await fetch("http://localhost:5000/routeNotExist?name=world", { method: 'GET'});
+        output = await output.json();
+        expect(output).eql({
+            "statusCode": 404,
+            "error": "Not Found",
+            "message": "Not Found"
+        });
+    });
 });