fix cli issues

Author: aidanhibbard

spec/cli.spec.ts

@@ -54,6 +54,7 @@ describe('CLI dev command', () => {
   let signalHandlers: Record<string, Array<(...args: unknown[]) => void>>
 
   beforeEach(() => {
+    _spawnCalled = false
     tmpDir = mkdtempSync(join(os.tmpdir(), 'nuxt-processor-cli-'))
     // minimal package.json
     writeFileSync(join(tmpDir, 'package.json'), JSON.stringify({ name: 'app', version: '0.0.0', scripts: {} }, null, 2))
@@ -147,10 +148,29 @@ describe('CLI dev command', () => {
     expect(pkg2.scripts && pkg2.scripts['processor:dev']).toBe('nuxt-processor dev')
   })
 
+  it('exits when entry exists but processor:dev script could not be ensured', async () => {
+    const entryDir = join(tmpDir, '.nuxt', 'dev', 'workers')
+    mkdirSync(entryDir, { recursive: true })
+    writeFileSync(join(entryDir, 'index.mjs'), 'export {}\n')
+    promptAnswer = 'n'
+    const { main } = await importCli()
+    try {
+      await main({ rawArgs: ['dev', tmpDir] })
+    }
+    catch (e) {
+      expect(String(e)).toContain('process.exit(1)')
+    }
+    expect(_spawnCalled).toBe(false)
+  })
+
   it('kills child process on SIGINT signal', async () => {
     const entryDir = join(tmpDir, '.nuxt', 'dev', 'workers')
     mkdirSync(entryDir, { recursive: true })
     writeFileSync(join(entryDir, 'index.mjs'), 'export {}\n')
+    const pkgPath = join(tmpDir, 'package.json')
+    const pkg = JSON.parse(readFileSync(pkgPath, 'utf8')) as { scripts?: Record<string, string> }
+    pkg.scripts = { ...(pkg.scripts || {}), 'processor:dev': 'nuxt-processor dev' }
+    writeFileSync(pkgPath, JSON.stringify(pkg, null, 2))
 
     promptAnswer = 'n'
     const { main } = await importCli()
@@ -175,6 +195,10 @@ describe('CLI dev command', () => {
     const entryDir = join(tmpDir, '.nuxt', 'dev', 'workers')
     mkdirSync(entryDir, { recursive: true })
     writeFileSync(join(entryDir, 'index.mjs'), 'export {}\n')
+    const pkgPath = join(tmpDir, 'package.json')
+    const pkg = JSON.parse(readFileSync(pkgPath, 'utf8')) as { scripts?: Record<string, string> }
+    pkg.scripts = { ...(pkg.scripts || {}), 'processor:dev': 'nuxt-processor dev' }
+    writeFileSync(pkgPath, JSON.stringify(pkg, null, 2))
 
     promptAnswer = 'n'
     const { main } = await importCli()

src/cli.ts

@@ -42,7 +42,7 @@ export const main = createMain({
         const indexFile = resolve(projectRoot, '.nuxt/dev/workers/index.mjs')
         const watchDir = resolve(projectRoot, '.nuxt/dev/workers')
 
-        await ensureProcessorDevScript(projectRoot)
+        const scriptEnsured = await ensureProcessorDevScript(projectRoot)
 
         if (!existsSync(indexFile)) {
           logger.error('No entry file found at .nuxt/dev/workers/index.mjs')
@@ -51,6 +51,11 @@ export const main = createMain({
           process.exit(1)
         }
 
+        if (!scriptEnsured) {
+          logger.error('Could not ensure processor:dev script in package.json.')
+          process.exit(1)
+        }
+
         const nodeBin = process.execPath
         const nodeArgsInput = Array.isArray(args.nodeArgs)
           ? args.nodeArgs

src/utils/ensure-processor-dev-script.ts

@@ -39,9 +39,19 @@ export async function ensureProcessorDevScript(
 
   logger.warn('No "processor:dev" script found in package.json.')
 
-  const answer = options?.ask
-    ? await options.ask()
-    : await createInterface({ input, output }).question('Add script to package.json? (y/N) ')
+  let answer: string
+  if (options?.ask) {
+    answer = await options.ask()
+  }
+  else {
+    const rl = createInterface({ input, output })
+    try {
+      answer = await rl.question('Add script to package.json? (y/N) ')
+    }
+    finally {
+      rl.close()
+    }
+  }
 
   const isYes = typeof answer === 'string' && /^y(?:es)?$/i.test(answer.trim())
   if (!isYes) {