Skip to content

Commit 3d79c31

Browse files
committed
fix: testie
1 parent 20e1d33 commit 3d79c31

File tree

1 file changed

+22
-10
lines changed

1 file changed

+22
-10
lines changed

.github/workflows/test-expect.yml

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,29 @@ jobs:
4444
env:
4545
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
4646
run: >-
47-
pnpm dlx expect-cli@0.0.10 -y -m
48-
"Test the element properties panel feature at http://localhost:5175.
47+
pnpm dlx https://pkg.pr.new/expect-cli@eec6884 -y -m
48+
"Test only the element properties panel feature at http://localhost:5175.
49+
Do not explore unrelated flows. If a step is blocked after one retry, fail with evidence.
50+
4951
react-grab is a browser overlay tool that lets you inspect React elements.
50-
You activate it by holding the Meta/Ctrl key, then hovering over elements
51-
shows a selection label with the element tag name and component name.
52+
When active, hovering over elements shows a selection label with the element
53+
tag name and component name.
5254
53-
How to activate react-grab:
54-
1. Hold the Meta key (Cmd on Mac, Ctrl on Linux) for ~200ms to activate the overlay.
55-
2. While holding Meta, hover over elements to see the selection highlight.
56-
3. Click an element to select it — a selection label appears below it.
57-
4. Press arrow keys (Up/Down) to navigate the DOM tree (parent/child).
55+
Important repo-specific testing notes:
56+
1. This GitHub Actions run is on Linux, so the default activation shortcut is Ctrl+C.
57+
Do not try to activate react-grab by holding only Ctrl.
58+
2. React Grab is in toggle mode by default. Press Ctrl+C once to activate it,
59+
then hover elements and click to select them.
60+
3. If keyboard activation is flaky in CI, you may call window.__REACT_GRAB__.activate()
61+
from a Playwright evaluation instead.
62+
4. For assertions, prefer Playwright evaluation against the app state and shadow DOM
63+
over ARIA snapshots for the overlay UI.
64+
5. The overlay renders inside the shadow root of the element matching [data-react-grab].
65+
Helpful assertions can use window.__REACT_GRAB__.getState() and
66+
document.querySelector('[data-react-grab]')?.shadowRoot, especially
67+
[data-react-grab-selection-label].
68+
6. After activation, hover an element, click it to select it, then use ArrowUp / ArrowDown
69+
to navigate and verify the panel updates.
5870
5971
What changed in this branch:
6072
The old inspect stack (a list of ancestor elements you could arrow-navigate through)
@@ -69,7 +81,7 @@ jobs:
6981
- Box model overlay: margin regions rendered as semi-transparent overlay around the selection, padding regions rendered inside.
7082
7183
Test scenarios:
72-
1. Activate react-grab (hold Meta), hover over the Todo List heading, click to select it, then press ArrowUp to navigate to parent — verify the properties panel appears showing size, font info, and class names.
84+
1. Activate react-grab with Ctrl+C, hover over the Todo List heading, click to select it, then press ArrowUp to navigate to parent — verify the properties panel appears showing size, font info, and class names.
7385
2. Select a button element (e.g. Submit button in the form section) — navigate with arrows and verify the panel shows the buttons role as button and keyboard-focusable as Yes.
7486
3. Select a text element and check that color swatches appear next to Color and Background values.
7587
4. Select a table cell and verify the accessibility section shows role cell.

0 commit comments

Comments
 (0)