refactor: apply full audit report improvements to react-grab (#262)

Co-authored-by: aiden <aiden@million.dev>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: aidenybai

packages/react-grab/src/components/selection-label/index.tsx

@@ -179,10 +179,10 @@ export const SelectionLabel: Component<SelectionLabelProps> = (props) => {
       const currentElementIdentity = elementIdentity();
       const didReset =
         currentElementIdentity !== previousResult.elementIdentity;
-      const cached = didReset
+      const cached: PositionResult = didReset
         ? {
             position: DEFAULT_OFFSCREEN_POSITION,
-            computedArrowPosition: null as ArrowPosition | null,
+            computedArrowPosition: null,
             hadValidBounds: false,
             elementIdentity: currentElementIdentity,
           }
@@ -298,10 +298,10 @@ export const SelectionLabel: Component<SelectionLabelProps> = (props) => {
     },
     {
       position: DEFAULT_OFFSCREEN_POSITION,
-      computedArrowPosition: null as ArrowPosition | null,
+      computedArrowPosition: null,
       hadValidBounds: false,
       elementIdentity: "",
-    },
+    } satisfies PositionResult,
   );
 
   const arrowPosition = () =>

packages/react-grab/src/core/auto-scroll.ts

@@ -65,10 +65,6 @@ export const createAutoScroller = (
     }
   };
 
-  const start = () => {
-    scroll();
-  };
-
   const stop = () => {
     if (animationId !== null) {
       nativeCancelAnimationFrame(animationId);
@@ -79,7 +75,7 @@ export const createAutoScroller = (
   const isActive = () => animationId !== null;
 
   return {
-    start,
+    start: scroll,
     stop,
     isActive,
   };