Commit e5ab8e1
committed
Revert label-manager/dropdown-controller overabstractions, fix flaky viewport test
- Inline label-manager.ts and dropdown-controller.ts back into core/index.tsx —
they created DI interfaces for code with exactly one consumer
- Keep the actual improvements: cancelAllLabelFades() for orphaned timer cleanup,
clearAllLabels() for combined clear+cancel
- Fix flaky "should handle elements outside viewport" test: use scrollIntoViewIfNeeded()
instead of fixed scrollPage(1000) which was viewport-size-dependent
584/584 e2e tests pass, 0 flaky.
Made-with: Cursor1 parent b5d3ac6 commit e5ab8e1
File tree
4 files changed
+189
-278
lines changed- packages/react-grab
- e2e
- src/core
4 files changed
+189
-278
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
327 | | - | |
328 | | - | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
329 | 331 | | |
330 | 332 | | |
331 | 333 | | |
| |||
This file was deleted.
0 commit comments