refactor(core): Remove unused code and optimize conditions

Author: aidenybai

package.json

@@ -23,7 +23,6 @@
     "email": "[email protected]",
     "url": "https://million.dev"
   },
-  "sideEffects": false,
   "type": "commonjs",
   "exports": {
     "./package.json": "./package.json",

src/core/index.ts

@@ -171,9 +171,8 @@ export const start = () => {
     onRender(fiber, render) {
       options.onRender?.(fiber, render);
       const outline = getOutline(fiber, render);
-      if (outline) {
-        ReactScanInternals.scheduledOutlines.push(outline);
-      }
+      if (!outline) return;
+      ReactScanInternals.scheduledOutlines.push(outline);
 
       if (options.playSound && audioContext) {
         const renderTimeThreshold = 10;
@@ -194,31 +193,6 @@ export const start = () => {
 
       requestAnimationFrame(() => {
         flushOutlines(ctx, new Map(), toolbar, perfObserver);
-
-        // const fiberData = ReactScanInternals.fiberMap.get(fiber);
-        // const now = Date.now();
-        // let count = render.count;
-        // let time = render.time;
-        // if (fiberData) {
-        //   // clear aggregated fibers after 5 seconds
-        //   if (
-        //     now - fiberData.lastUpdated >
-        //     (options.resetCountTimeout ?? 5000)
-        //   ) {
-        //     ReactScanInternals.fiberMap.delete(fiber);
-        //   } else {
-        //     count += fiberData.count;
-        //     time += fiberData.time;
-        //     render.count = count;
-        //     render.time = time;
-        //   }
-        // }
-
-        // ReactScanInternals.fiberMap.set(fiber, {
-        //   count,
-        //   time,
-        //   lastUpdated: now,
-        // });
       });
     },
     onCommitFinish() {

src/core/web/outline.ts

@@ -5,6 +5,7 @@ import { ReactScanInternals } from '../index';
 import { getLabelText } from '../utils';
 import { isOutlineUnstable, throttle } from './utils';
 import { log } from './log';
+import { recalcOutlineColor } from './perf-observer';
 // import { recalcOutlineColor } from './perf-observer';
 
 export interface PendingOutline {
@@ -38,19 +39,7 @@ export const getOutlineKey = (outline: PendingOutline): string => {
   return `${outline.rect.top}-${outline.rect.left}-${outline.rect.width}-${outline.rect.height}`;
 };
 
-const getRectCache = new WeakMap<
-  HTMLElement,
-  { rect: DOMRect; timestamp: number }
->();
-
 export const getRect = (domNode: HTMLElement): DOMRect | null => {
-  const cachedRect = getRectCache.get(domNode);
-  if (
-    cachedRect &&
-    performance.now() - cachedRect.timestamp < DEFAULT_THROTTLE_TIME
-  ) {
-    return cachedRect.rect;
-  }
   const style = window.getComputedStyle(domNode);
   if (
     style.display === 'none' ||
@@ -63,17 +52,15 @@ export const getRect = (domNode: HTMLElement): DOMRect | null => {
   const rect = domNode.getBoundingClientRect();
 
   const isVisible =
-    rect.top >= 0 ||
-    rect.left >= 0 ||
-    rect.bottom <= window.innerHeight ||
+    rect.top >= 0 &&
+    rect.left >= 0 &&
+    rect.bottom <= window.innerHeight &&
     rect.right <= window.innerWidth;
 
   if (!isVisible || !rect.width || !rect.height) {
     return null;
   }
 
-  getRectCache.set(domNode, { rect, timestamp: performance.now() });
-
   return rect;
 };
 
@@ -168,7 +155,7 @@ export const flushOutlines = (
 
   requestAnimationFrame(() => {
     if (perfObserver) {
-      // recalcOutlineColor(perfObserver.takeRecords());
+      recalcOutlineColor(perfObserver.takeRecords());
     }
     recalcOutlines();
     void (async () => {