Skip to content

Commit 1f7a6d2

Browse files
committed
remove one more TODO
1 parent d71346d commit 1f7a6d2

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

python/private/pypi/evaluate_markers.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ def evaluate_markers(*, requirements, platforms):
4343
for req_string, platform_strings in requirements.items():
4444
req = requirement(req_string)
4545
for platform_str in platform_strings:
46-
env = platforms.get(platform_str)
47-
if not env:
46+
plat = platforms.get(platform_str)
47+
if not plat:
4848
continue
4949

50-
if evaluate(req.marker, env = env):
50+
if evaluate(req.marker, env = plat.env):
5151
ret.setdefault(req_string, []).append(platform_str)
5252

5353
return ret

python/private/pypi/extension.bzl

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,11 @@ def _create_whl_repos(
196196
elif config.enable_pipstar:
197197
evaluate_markers = lambda _, requirements: evaluate_markers_star(
198198
requirements = requirements,
199-
platforms = {
200-
k: p.env
201-
# TODO @aignas 2025-07-05: update evaluate_markers_star
202-
for k, p in _platforms(
203-
python_version = pip_attr.python_version,
204-
minor_mapping = minor_mapping,
205-
config = config,
206-
).items()
207-
},
199+
platforms = _platforms(
200+
python_version = pip_attr.python_version,
201+
minor_mapping = minor_mapping,
202+
config = config,
203+
),
208204
)
209205
else:
210206
# NOTE @aignas 2024-08-02: , we will execute any interpreter that we find either

0 commit comments

Comments
 (0)