Issue with using VScode as the default profile editor

[yakutovicha]

A colleague of mine tried to update a profile configuration with VScode as a default editor.
Unfortunately, any time she would run:

aiidalab-launch profile edit <name>

She would get an empty toml file to edit. After switching back to vim:

export VISUAL=vim
export EDITOR="$VISUAL"

Things worked fine

[yakutovicha]

After some googling I found that adding "--wait" option resolves the issue for the VScode. We might need to add this option to aiidalab-launch as well.

[danielhollas]

Oh, interesting observation, good to know.

It seems based on that StackOverflow answer that the fix needs to be done on the "shell" level?
In aiidalab-launch we use click.edit() for this functionality. It seems it doesn't allow passing additional parameter, but allows setting environment variables. I wonder if that is an option for VSCode?

https://click.palletsprojects.com/en/8.1.x/api/#click.edit

[yakutovicha]

Sorry, @danielhollas, I don't have answers to those questions at the moment. I made this issue only for the sake of reporting. I might come to this issue later, for now I do not have time to investigate it further.