Apply testing review from Timo

Author: agoscinski

src/aiida/cmdline/commands/cmd_process.py

@@ -28,11 +28,11 @@
 ACTION_TIMEOUT = OverridableOption(
     '-t',
     '--timeout',
-    type=click.FLOAT,
+    type=click.FloatRange(0, float('inf')),
     default=float('inf'),
     show_default=True,
     help='Time in seconds to wait for a response before timing out. '
-    'If timeout <= 0 the command does not wait for response.',
+    'If timeout is 0 the command does not wait for response.',
 )
 
 

src/aiida/engine/processes/control.py

@@ -229,6 +229,7 @@ def _perform_actions(
 
         try:
             future = action(process.pk, **kwargs)
+            LOGGER.report(f'Request to {infinitive} Process<{process.pk}> sent.')
         except communications.UnroutableError:
             LOGGER.error(f'Process<{process.pk}> is unreachable.')
         else:
@@ -254,10 +255,15 @@ def _resolve_futures(
     :param present: The present tense form of the action verb.
     :param timeout: Raise a ``ProcessTimeoutException`` if the process does not respond within this amount of seconds.
     """
-    if not timeout:
+    if not timeout or not futures:
+        if futures:
+            LOGGER.report(
+                f"Request to {infinitive} process(es) {','.join([str(proc.pk) for proc in futures.values()])}"
+                ' sent. Skipping waiting for response.'
+            )
         return
 
-    LOGGER.report(f"Waiting for process(es) {','.join([str(proc.pk) for proc in futures.values()])}")
+    LOGGER.report(f"Waiting for process(es) {','.join([str(proc.pk) for proc in futures.values()])}.")
 
     # Ensure that when futures are only are completed if they return an actual value (not a future)
     unwrapped_futures = {unwrap_kiwi_future(future): process for future, process in futures.items()}
@@ -273,7 +279,7 @@ def _resolve_futures(
                 LOGGER.error(f'Failed to {infinitive} Process<{process.pk}>: {exception}')
             else:
                 if result is True:
-                    LOGGER.report(f'Request to {infinitive} Process<{process.pk}> sent')
+                    LOGGER.report(f'Request to {infinitive} Process<{process.pk}> processed.')
                 elif result is False:
                     LOGGER.error(f'Problem {present} Process<{process.pk}>')
                 else:

tests/cmdline/commands/test_process.py

@@ -217,7 +217,7 @@ def make_a_builder(sleep_seconds=0):
 
         # practice a normal kill, which should fail
         result = run_cli_command(cmd_process.process_kill, [str(node.pk), '--timeout', '1.0'])
-        assert f'Error: call to kill Process<{node.pk}> timed out' in result.stdout
+        assert f'Error: Call to kill Process<{node.pk}> timed out' in result.stdout
 
         # force kill the process
         result = run_cli_command(cmd_process.process_kill, [str(node.pk), '-F'])