Fix some typing issues

Author: edan-bainglass

src/aiida/cmdline/commands/cmd_code.py

@@ -38,7 +38,7 @@ def verdi_code():
 def create_code(ctx: click.Context, cls: 'Code', **kwargs) -> None:
     """Create a new `Code` instance."""
     try:
-        Model = cls.Model.as_input_model()
+        Model = cls.Model.as_input_model()  # noqa: N806
         instance = cls.from_model(Model(**kwargs))
     except (TypeError, ValueError) as exception:
         echo.echo_critical(f'Failed to create instance `{cls}`: {exception}')

src/aiida/cmdline/groups/dynamic.py

@@ -97,7 +97,7 @@ def call_command(self, ctx: click.Context, cls: t.Any, non_interactive: bool, **
 
         if hasattr(cls, 'Model'):
             # The plugin defines a pydantic model: use it to validate the provided arguments
-            Model = cls.Model.as_input_model() if hasattr(cls.Model, 'as_input_model') else cls.Model
+            Model = cls.Model.as_input_model() if hasattr(cls.Model, 'as_input_model') else cls.Model  # noqa: N806
             try:
                 Model(**kwargs)
             except ValidationError as exception:
@@ -169,7 +169,7 @@ def list_options(self, entry_point: str) -> list[t.Callable[[FC], FC]]:
             options_spec = self.factory(entry_point).get_cli_options()  # type: ignore[union-attr]
             return [self.create_option(*item) for item in options_spec]
 
-        Model = cls.Model.as_input_model() if hasattr(cls.Model, 'as_input_model') else cls.Model
+        Model = cls.Model.as_input_model() if hasattr(cls.Model, 'as_input_model') else cls.Model  # noqa: N806
 
         options_spec = {}
 

src/aiida/orm/entities.py

@@ -14,7 +14,7 @@
 import pathlib
 from enum import Enum
 from functools import lru_cache
-from typing import TYPE_CHECKING, Any, Generic, List, Literal, Optional, Type, TypeVar, Union, cast
+from typing import TYPE_CHECKING, Any, Generic, List, Literal, Optional, Type, TypeVar, Union
 
 from plumpy.base.utils import call_with_super_check, super_check
 from pydantic import BaseModel, ConfigDict, create_model
@@ -95,7 +95,7 @@ def __call__(self, backend: 'StorageBackend') -> Self:
         """Get or create a cached collection using a new backend."""
         if backend is self._backend:
             return self
-        return self.get_cached(self.entity_type, backend=backend)  # type: ignore[arg-type]
+        return self.get_cached(self.entity_type, backend=backend)
 
     @property
     def entity_type(self) -> Type[EntityType]:
@@ -213,7 +213,7 @@ def as_input_model(cls: Type[EntityModelType]) -> Type[EntityModelType]:
 
             # Derive the input model from the original model
             new_name = cls.__qualname__.replace('.Model', 'InputModel')
-            InputModel = create_model(
+            InputModel = create_model(  # noqa: N806
                 new_name,
                 __base__=cls,
                 __doc__=f'Input version of {cls.__name__}.',
@@ -225,7 +225,9 @@ def as_input_model(cls: Type[EntityModelType]) -> Type[EntityModelType]:
             readonly_fields = [
                 name
                 for name, field in InputModel.model_fields.items()
-                if getattr(field, 'json_schema_extra', {}) and field.json_schema_extra.get('readOnly')
+                if hasattr(field, 'json_schema_extra')
+                and isinstance(field.json_schema_extra, dict)
+                and field.json_schema_extra.get('readOnly')
             ]
 
             # Remove read-only fields
@@ -247,7 +249,7 @@ def _prune_field_decorators(field_decorators: dict[str, Any]) -> dict[str, Any]:
             decorators.field_validators = _prune_field_decorators(decorators.field_validators)
             decorators.field_serializers = _prune_field_decorators(decorators.field_serializers)
 
-            return cast(Type[EntityModelType], InputModel)
+            return InputModel
 
     @classmethod
     def model_to_orm_fields(cls) -> dict[str, FieldInfo]:
@@ -297,7 +299,7 @@ def to_model(self, repository_path: Optional[pathlib.Path] = None, unstored: boo
         """
         fields = {}
 
-        Model = self.Model.as_input_model() if unstored else self.Model
+        Model = self.Model.as_input_model() if unstored else self.Model  # noqa: N806
 
         for key, field in Model.model_fields.items():
             if orm_to_model := get_metadata(field, 'orm_to_model'):
@@ -360,7 +362,7 @@ def from_serialized(cls, unstored: bool = False, **kwargs: dict[str, Any]) -> 'E
         cls._logger.warning(
             'Serialization through pydantic is still an experimental feature and might break in future releases.'
         )
-        Model = cls.Model.as_input_model() if unstored else cls.Model
+        Model = cls.Model.as_input_model() if unstored else cls.Model  # noqa: N806
         return cls.from_model(Model(**kwargs))  # type: ignore[arg-type]
 
     @classproperty

src/aiida/orm/groups.py

@@ -123,7 +123,7 @@ class Model(entities.Entity.Model):
             exclude_to_orm=True,
         )
         user: int = MetadataField(
-            default_factory=lambda: users.User.collection.get_default().pk,
+            default_factory=lambda: users.User.collection.get_default().pk,  # type: ignore[union-attr]
             description='The PK of the group owner, defaults to the current user',
             is_attribute=False,
             orm_class='core.user',

src/aiida/orm/nodes/data/array/trajectory.py

@@ -43,7 +43,6 @@ class Model(ArrayData.Model):
         )
         symbols: List[str] = MetadataField(description='List of symbols')
 
-
     def __init__(
         self,
         structurelist: list[orm.StructureData] | None = None,
@@ -105,7 +104,7 @@ def _internal_validate(self, stepids, cells, symbols, positions, times, velociti
         numatoms = len(symbols)
         if positions.shape != (numsteps, numatoms, 3):
             raise ValueError(
-                'TrajectoryData.positions must have shape (s,n,3), ' 'with s=number of steps and n=number of symbols'
+                'TrajectoryData.positions must have shape (s,n,3), with s=number of steps and n=number of symbols'
             )
         if times is not None:
             if times.shape != (numsteps,):
@@ -426,7 +425,7 @@ def get_step_structure(self, index, custom_kinds=None):
             for k in custom_kinds:
                 if not isinstance(k, Kind):
                     raise TypeError(
-                        'Each element of the custom_kinds list must ' 'be a aiida.orm.nodes.data.structure.Kind object'
+                        'Each element of the custom_kinds list must be a aiida.orm.nodes.data.structure.Kind object'
                     )
                 kind_names.append(k.name)
             if len(kind_names) != len(set(kind_names)):