Send Slack notification if test-install.yml fails (#6897)

* Add slack-notification action, use it in test-install.yml
* Don't run on PRs

Author: danielhollas

.github/actions/slack-notification/action.yml

@@ -0,0 +1,23 @@
+name: Slack notification
+description: Send message to aiida-core-dev channel
+
+inputs:
+  title:
+    description: Message title
+    required: true
+  message:
+    description: Text of the message
+    required: true
+
+runs:
+  using: composite
+  steps:
+
+  - name: Slack notification
+    uses: rtCamp/action-slack-notify@v2
+    env:
+      SLACK_ICON: https://www.materialscloud.org/discover/images/0ba0a17d.aiida-logo-128.png
+      SLACK_CHANNEL: dev-aiida-core
+      SLACK_COLOR: b60205
+      SLACK_TITLE: ${{ inputs.title }}
+      SLACK_MESSAGE: ${{ inputs.message }}

.github/workflows/nightly.yml

@@ -82,18 +82,23 @@ jobs:
       run: .github/workflows/daemon_tests.sh
 
     - name: Slack notification
-      # Always run this step (otherwise it would be skipped if any of the previous steps fail) but only if the
-      # `install` or `tests` steps failed, and the `SLACK_WEBHOOK` is available. The latter is not the case for
-      # pull requests that come from forks. This is a limitation of secrets on GHA
-      if: always() && (steps.install.outcome == 'failure' || steps.pytest-tests.outcome == 'failure' || steps.daemon-tests.outcome == 'failure') && env.SLACK_WEBHOOK != null
-      uses: rtCamp/action-slack-notify@v2
+      # Always run this step (otherwise it would be skipped if any of the previous steps fail)
+      # but only if the `install` or `tests` steps failed.
+      # Don't run on PRs, the failure is clearly visible in GitHub UI.
+      # Run only when the `secrets.SLACK_WEBHOOK` is available, which is not the case for forks.
+      if: >-
+        always() &&
+        (steps.install.outcome == 'failure' ||
+         steps.pytest-tests.outcome == 'failure' ||
+         steps.daemon-tests.outcome == 'failure') &&
+        github.event_name != 'pull_request' &&
+        env.SLACK_WEBHOOK != null
+      uses: ./.github/actions/slack-notification
       env:
         SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-        SLACK_ICON: https://www.materialscloud.org/discover/images/0ba0a17d.aiida-logo-128.png
-        SLACK_CHANNEL: dev-aiida-core
-        SLACK_COLOR: b60205
-        SLACK_TITLE: Nightly build of `aiida-core/main` failed
-        SLACK_MESSAGE: The tests of the `nightly.yml` GHA worklow failed.
+      with:
+        title: Nightly build of `aiida-core/main` failed
+        message: The tests of the `nightly.yml` GHA worklow failed.
 
 
   # Run a subset of test suite to ensure compatibility with latest RabbitMQ releases
@@ -139,15 +144,18 @@ jobs:
       run: pytest -s --db-backend sqlite -m 'requires_rmq' tests/
 
     - name: Slack notification
-      # Always run this step (otherwise it would be skipped if any of the previous steps fail) but only if the
-      # `install` or `tests` steps failed, and the `SLACK_WEBHOOK` is available. The latter is not the case for
-      # pull requests that come from forks. This is a limitation of secrets on GHA
-      if: always() && (steps.install.outcome == 'failure' || steps.tests.outcome == 'failure') && env.SLACK_WEBHOOK != null
-      uses: rtCamp/action-slack-notify@v2
+      # Always run this step (otherwise it would be skipped if any of the previous steps fail)
+      # but only if the `install` or `tests` steps failed.
+      # Don't run on PRs, the failure is clearly visible in GitHub UI.
+      # Run only when the `secrets.SLACK_WEBHOOK` is available, which is not the case for forks.
+      if: >-
+        always() &&
+        (steps.install.outcome == 'failure' || steps.tests.outcome == 'failure') &&
+        github.event_name != 'pull_request' &&
+        env.SLACK_WEBHOOK != null
+      uses: ./.github/actions/slack-notification
       env:
         SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-        SLACK_ICON: https://www.materialscloud.org/discover/images/0ba0a17d.aiida-logo-128.png
-        SLACK_CHANNEL: dev-aiida-core
-        SLACK_COLOR: b60205
-        SLACK_TITLE: RabbitMQ nightly tests of `aiida-core/main` failed
-        SLACK_MESSAGE: The rabbitmq tests in the `nightly.yml` GHA worklow failed.
+      with:
+        title: RabbitMQ nightly tests of `aiida-core/main` failed
+        message: RabbitMQ (${{ matrix.rabbitmq-version }}) tests in the `nightly.yml` GHA worklow failed.

.github/workflows/test-install.yml

@@ -195,6 +195,7 @@ jobs:
       run: sudo apt update && sudo apt install postgresql graphviz
 
     - name: Install aiida-core
+      id: install
       uses: ./.github/actions/install-aiida-core
       with:
         python-version: ${{ matrix.python-version }}
@@ -205,8 +206,26 @@ jobs:
       run: .github/workflows/setup.sh
 
     - name: Run test suite
+      id: tests
       env:
         AIIDA_TEST_PROFILE: test_aiida
         AIIDA_WARN_v3: 1
       run: |
         pytest -n auto --db-backend psql -m 'not nightly' tests/
+
+    - name: Slack notification
+      # Always run this step (otherwise it would be skipped if any of the previous steps fail)
+      # but only if the `install` or `tests` steps failed.
+      # Don't run on PRs, the failure is clearly visible in GitHub UI.
+      # Run only when the `secrets.SLACK_WEBHOOK` is available, which is not the case for forks.
+      if: >-
+        always() &&
+        (steps.install.outcome == 'failure' || steps.tests.outcome == 'failure') &&
+        github.event_name != 'pull_request' &&
+        env.SLACK_WEBHOOK != null
+      uses: ./.github/actions/slack-notification
+      env:
+        SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+      with:
+        title: Install tests of `aiida-core/main` failed
+        message: '`test-install.yml` GHA workflow for Python ${{ matrix.python-version }} failed.'