👌 Parser: add exit codes for diverging Hubbard parameters#110
Merged
👌 Parser: add exit codes for diverging Hubbard parameters#110
Conversation
When the value of an Hubbard parameter is too large, fortran converts it into a string such as `*****`. This makes it impossible to parse. At the same time, it is a signature that the Hubbard parameter is diverging, and therefore one should stop the self-consistent cycle as early as possible.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 86.28% 87.33% +1.05%
==========================================
Files 19 19
Lines 1538 1650 +112
==========================================
+ Hits 1327 1441 +114
+ Misses 211 209 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the value of an Hubbard parameter is too large,
fortran converts it into a string such as
*****. Thismakes it impossible to parse. At the same time, it is
a signature that the Hubbard parameter is diverging,
and therefore one should stop the self-consistent
cycle as early as possible.