Feature/Add mvp manual reviewer agent (#401)

* Reviewer MVP

* fix: args type errors

* add manual ReviewerAgent and adapt PlannerAgent for review loop

* add logging session_memory, fix planner reasoning display, fix pydantic warnings

* replace print with logger in run_chat.py

* fix condition commit and push

* fix: add logging

* refactor logging + add docstrings

* fix black

* fix tests after merge

* refactor: DocVal and PaperVal integrate in agents logic

* refactor: add proper logging events for agent logic

* fix black

* operations are wrapped in try except
fix WhatHasBeenDoneReportGenerator generation summary

* minor fices after merge

* fix typo + increment OSA version

Author: fl1pcoin

docs/core/operations/OPERATIONS.md

@@ -7,11 +7,13 @@ This document is auto-generated. Do not edit manually.
 | Name | Priority | Intents | Scopes | Args Schema | Executor | Method |
 |------|----------|---------|--------|-------------|----------|--------|
 | `generate_report` | 5 | new_task | full_repo, analysis | — | `ReportGenerator` | `build_pdf` |
+| `convert_notebooks` | 30 | new_task | full_repo, codebase | ConvertNotebooksArgs | `NotebookConverter` | `convert_notebooks` |
 | `translate_dirs` | 40 | new_task | full_repo, codebase | — | `RepositoryStructureTranslator` | `rename_directories_and_files` |
 | `generate_docstrings` | 50 | new_task, feedback | full_repo, codebase | GenerateDocstringsArgs | `DocstringsGenerator` | `run` |
 | `ensure_license` | 60 | new_task | full_repo, docs | EnsureLicenseArgs | `LicenseCompiler` | `run` |
 | `generate_documentation` | 65 | new_task | full_repo, docs | — | `generate_documentation` | `—` |
 | `generate_requirements` | 67 | new_task | full_repo, codebase | — | `RequirementsGenerator` | `generate` |
-| `generate_readme` | 70 | new_task, feedback | full_repo, docs | GenerateReadmeArgs | `ReadmeAgent` | `generate_readme` |
+| `generate_readme` | 70 | new_task, feedback | full_repo, docs | — | `ReadmeAgent` | `generate_readme` |
 | `translate_readme` | 75 | new_task, feedback | full_repo, docs | TranslateReadmeArgs | `ReadmeTranslator` | `translate_readme` |
-| `generate_about` | 80 | new_task | full_repo, docs | — | `AboutGenerator` | `generate_about_content` |
+| `generate_about` | 80 | new_task | full_repo, docs | — | `AboutGenerator` | `generate_about_content` |
+| `organize` | 90 | new_task | full_repo, codebase | — | `RepoOrganizer` | `organize` |

osa_tool/config/prompts/analysis.toml

@@ -49,131 +49,39 @@ RULES:
 
 """
 
-after_report_text_prompt = """
-DEFINITIONS:
-
-translate_dirs — Translate directory names to English
-convert_notebooks — Convert Jupyter notebooks to Python scripts
-translate_readme — Translate README file to English
-ensure_license — Ensure a LICENSE file is present
-community_docs — Add or update community documentation files
-docstring — Add or update docstrings in source code
-report — Generate refactoring report
-readme — Create a README file
-requirements — Add or update requirements file
-organize — Reorganize project structure
-about — Add project description or about section
-validate_paper — Validate academic paper files
-validate_doc — Validate documentation files
-generate_workflows — Generate CI or automation workflows
-include_tests — Add or include tests
-include_black — Add Black code formatter
-include_pep8 — Add PEP8 compliance checks
-include_autopep8 — Add autopep8 formatter
-include_fix_pep8 — Automatically fix PEP8 issues
-include_pypi — Prepare project for PyPI publishing
-python_versions — Specify supported Python versions
-pep8_tool — Configure PEP8 checking tool
-use_poetry — Use Poetry for dependency management
-include_codecov — Add Codecov integration
-
-
-INPUT DATA (tasks list):
-
-{tasks_list}
+after_report_summary_from_events_prompt = """
+INPUT DATA (operations list):
 
-TASK:
+{operations}
 
-Write a connected textual summary of the repository refactoring.
+TASK:
+Write a short factual summary of what was performed.
 
 REQUIREMENTS:
-- Write approximately two short paragraphs
-- Use plain text only
+- Use only operations with performed == Yes
+- Base the wording on the provided events and result fields
+- Keep it concise (about two short paragraphs)
 - Do not use markdown
 - Do not use bullet points or lists
-- Do NOT mention tasks that were not performed
-- Do NOT explain why something was not done
-- Do NOT use modal or speculative language (avoid words like "may", "might", "likely")
-- Describe only actions that were actually performed
-- Use neutral but natural technical language
-- Write in confident past tense
-- Base the text ONLY on tasks with value "Yes"
-
-STYLE:
-- Clear and readable
-- Slightly narrative, but professional
-- No bureaucratic or legalistic phrasing
-- No assumptions or interpretation beyond task definitions
 
 OUTPUT:
-Return only the text summary.
-Do not add any explanations or extra text.
+Return ONLY JSON matching the system message schema.
 """
 
-after_report_blocks_prompt = """
-TASK DEFINITIONS:
-
-translate_dirs — Translate directory names to English
-convert_notebooks — Convert Jupyter notebooks to Python scripts
-translate_readme — Translate README file to English
-ensure_license — Ensure a LICENSE file is present
-community_docs — Add or update community documentation files
-docstring — Add or update docstrings in source code
-report — Generate refactoring report
-readme — Create a README file
-requirements — Add or update requirements file
-organize — Reorganize project structure
-about — Add project description or about section
-validate_paper — Validate academic paper files
-validate_doc — Validate documentation files
-generate_workflows — Generate CI or automation workflows
-include_tests — Add or include tests
-include_black — Add Black code formatter
-include_pep8 — Add PEP8 compliance checks
-include_autopep8 — Add autopep8 formatter
-include_fix_pep8 — Automatically fix PEP8 issues
-include_pypi — Prepare project for PyPI publishing
-python_versions — Specify supported Python versions
-pep8_tool — Configure PEP8 checking tool
-use_poetry — Use Poetry for dependency management
-include_codecov — Add Codecov integration
-
-
-INPUT DATA (tasks list):
-
-{tasks_list}
-
-TASK:
-
-You must summarize the result of repository refactoring based ONLY on the tasks listed above.
-
-Group tasks into logical blocks.
-Each logical block must contain:
-- a short name (plain sentence)
-- a short description (plain sentence)
-- a list of task numbers that belong to this block
+after_report_blocks_from_events_prompt = """
+INPUT DATA (operations list):
 
-OUTPUT FORMAT:
+{operations}
 
-Return ONLY valid JSON.
-No extra text, no explanations, no markdown.
-
-JSON structure:
-[
-  {{
-    "name": "Block name as a plain sentence",
-    "description": "Short description as a plain sentence",
-    "tasks": [1, 2]
-  }}
-]
-
-RULES (IMPORTANT):
+TASK:
+Group performed operations into logical blocks.
 
-1. Use double quotes only
-2. Output must be valid JSON
-3. Use ONLY task numbers from the input list
-4. Every task from 1 to 7 MUST be used exactly once
-5. Do NOT invent new tasks
-7. "tasks" must contain only numbers
+REQUIREMENTS:
+- Include ONLY operations with performed == Yes
+- Each performed operation must appear in exactly one block
+- "tasks" must list operation names exactly as provided (strings)
+- Do not invent operations
 
+OUTPUT:
+Return ONLY JSON matching the system message schema.
 """

osa_tool/config/prompts/osa_agent.toml

@@ -1,20 +1,23 @@
 [prompts]
 intent_router = """
-Analyze the following user request and any attached context:
+Analyze the following active request and any attached context:
 
-User Request: {user_request}
+Active Request: {active_request}
 Attachment: {attachment}
 
 Return the result **strictly in the JSON format described above**.
 """
 
 planner = """
-User request:
-{user_request}
+Active Request:
+{active_request}
 
 Detected intent: {intent}
 Task scope: {task_scope}
 
+Plan history:
+{plan_history_section}
+
 Repository overview:
 {repo_data}
 
@@ -25,13 +28,39 @@ Select the operations that best satisfy the user request.
 """
 
 detect_arguments = """
-User request:
-{user_request}
+Active Request:
+{active_request}
 
 Operations with additional arguments:
 {operations}
 """
 
+fill_missing_after_clarification = """
+Missing Fields (to fill):
+{missing}
+
+User Provided Answers:
+{user_answers}
+"""
+
+reviewer_user_prompt = """
+User feedback received: {feedback_text}
+
+Current workflow configuration:
+- Current intent: {current_intent}
+- Current task_scope: {current_task_scope}
+
+Analyze the feedback and determine:
+
+1. Does it require a new intent? (set "requires_new_intent")
+2. Does it require only a new or updated task_scope? (set "requires_new_task_scope")
+3. If new intent or task_scope is required, fill in "new_intent" and/or "new_task_scope".
+4. If no changes are needed, leave new_intent and new_task_scope as null.
+5. Provide a short summary in "reviewer_summary" explaining your decision.
+
+Return the output **strictly in JSON format** as specified in the system message.
+"""
+
 pr_summarizer = """
 Summarize the following repository changes into a Pull Request description.