Skip to content

Commit 80d7ca2

Browse files
Snawootsaghul
authored andcommitted
add tests indicating timeouts does not really work
1 parent 40cb14c commit 80d7ca2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import unittest
66
import socket
77
import sys
8+
import time
89

910
import aiodns
1011

@@ -101,10 +102,13 @@ def test_query_timeout(self):
101102
self.resolver = aiodns.DNSResolver(timeout=0.1, loop=self.loop)
102103
self.resolver.nameservers = ['1.2.3.4']
103104
f = self.resolver.query('google.com', 'A')
105+
started = time.monotonic()
104106
try:
105107
self.loop.run_until_complete(f)
106108
except aiodns.error.DNSError as e:
107109
self.assertEqual(e.args[0], aiodns.error.ARES_ETIMEOUT)
110+
# Ensure timeout really cuts time deadline. Limit duration to one second
111+
self.assertLess(time.monotonic() - started, 1)
108112

109113
def test_query_cancel(self):
110114
f = self.resolver.query('google.com', 'A')

0 commit comments

Comments
 (0)