Skip to content

Commit de038ba

Browse files
Fix reference field filter (#825)
1 parent 22049d5 commit de038ba

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

aiohttp_admin/backends/abc.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,7 @@ async def _get_list(self, request: web.Request) -> web.Response:
179179
query["sort"]["field"] = self.primary_key
180180
id_filter = query["filter"].pop("id", None)
181181
if id_filter is not None:
182-
if not isinstance(id_filter, str): # str used for like filtering.
183-
id_filter = check(self._id_type, id_filter)
182+
id_filter = check(self._id_type, id_filter)
184183
query["filter"][self.primary_key] = id_filter
185184

186185
# Add filters from advanced permissions.

tests/test_views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import re
33
from collections.abc import Awaitable, Callable
44

5+
import pytest
56
import sqlalchemy as sa
67
from aiohttp.test_utils import TestClient
78

@@ -89,6 +90,7 @@ async def test_list_filtering_by_pk(admin_client: TestClient, login: _Login) ->
8990
assert await resp.json() == {"data": [{"id": "3"}], "total": 1}
9091

9192

93+
@pytest.mark.xfail(reason="Need to implement #668 to make this work properly")
9294
async def test_list_text_like_filtering(admin_client: TestClient, login: _Login) -> None:
9395
h = await login(admin_client)
9496
assert admin_client.app

0 commit comments

Comments
 (0)