Skip to content

Commit 40b52b4

Browse files
committed
Don't introduce unneeded dependencies
1 parent d312b25 commit 40b52b4

File tree

3 files changed

+11
-15
lines changed

3 files changed

+11
-15
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,10 @@ install:
1717
- pip install aioredis
1818
- pip install cryptography
1919
- pip install docker-py
20-
- pip install pymemcache
2120
- pip install pynacl
2221
- pip install pytest
2322
- pip install pytest-aiohttp
2423
- pip install pytest-cov
25-
- pip install redis
2624
- pip install codecov
2725
- pip install aiomcache
2826
- python setup.py develop

requirements-dev.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ pep257==0.7.0
66
aioredis==0.3.4
77
cryptography==2.1.3
88
docker-py==1.10.6
9-
pymemcache==1.4.3
109
pynacl==1.2.0
1110
pytest-aiohttp==0.1.3
1211
pytest-cov==2.5.1
13-
redis==2.10.6
1412
aiohttp==2.3.2
1513
multidict==3.3.2
1614
chardet==3.0.4

tests/conftest.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
import asyncio
44
import gc
55
import pytest
6-
import redis as redisdb
76
import time
87
import uuid
98
from docker import Client as DockerClient
10-
from pymemcache.client.base import Client
119

1210

13-
@pytest.yield_fixture
11+
@pytest.yield_fixture(scope='session')
1412
def loop(request):
1513
loop = asyncio.new_event_loop()
1614
asyncio.set_event_loop(None)
@@ -42,7 +40,7 @@ def pytest_addoption(parser):
4240

4341

4442
@pytest.yield_fixture(scope='session')
45-
def redis_server(docker, session_id, request):
43+
def redis_server(docker, session_id, loop, request):
4644
if not request.config.option.no_pull:
4745
docker.pull('redis:{}'.format('latest'))
4846
container = docker.create_container(
@@ -57,10 +55,12 @@ def redis_server(docker, session_id, request):
5755
delay = 0.001
5856
for i in range(100):
5957
try:
60-
conn = redisdb.StrictRedis(host=host, port=6379, db=0)
61-
conn.set('foo', 'bar')
58+
conn = loop.run_until_complete(
59+
aioredis.create_connection((host, 6379))
60+
)
61+
loop.run_until_complete(conn.execute('SET', 'foo', 'bar'))
6262
break
63-
except redisdb.exceptions.ConnectionError as e:
63+
except ConnectionRefusedError as e:
6464
time.sleep(delay)
6565
delay *= 2
6666
else:
@@ -77,7 +77,7 @@ def redis_params(redis_server):
7777
return dict(**redis_server['redis_params'])
7878

7979

80-
@pytest.yield_fixture()
80+
@pytest.yield_fixture
8181
def redis(loop, redis_params):
8282
pool = None
8383

@@ -97,7 +97,7 @@ def start(*args, no_loop=False, **kwargs):
9797

9898

9999
@pytest.yield_fixture(scope='session')
100-
def memcached_server(docker, session_id, request):
100+
def memcached_server(docker, session_id, loop, request):
101101
if not request.config.option.no_pull:
102102
docker.pull('memcached:{}'.format('latest'))
103103
container = docker.create_container(
@@ -112,8 +112,8 @@ def memcached_server(docker, session_id, request):
112112
delay = 0.001
113113
for i in range(100):
114114
try:
115-
client = Client((host, 11211))
116-
client.set('foo', 'bar')
115+
conn = aiomcache.Client(host, 11211, loop=loop)
116+
loop.run_until_complete(conn.set(b'foo', b'bar'))
117117
break
118118
except ConnectionRefusedError as e:
119119
time.sleep(delay)

0 commit comments

Comments
 (0)