Skip to content

Commit d740590

Browse files
Bump redis from 5.0.0 to 5.0.1 (#931)
* Bump redis from 5.0.0 to 5.0.1 Bumps [redis](https://github.com/redis/redis-py) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update test_redis_storage.py * Update conftest.py * Update requirements-dev.txt * Update redis_storage.py * Update requirements-dev.txt * Update conftest.py * Update redis_storage.py * Update redis_storage.py * Update test_redis_storage.py --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Bull <[email protected]>
1 parent 1ffc82e commit d740590

File tree

6 files changed

+26
-27
lines changed

6 files changed

+26
-27
lines changed

aiohttp_session/redis_storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class RedisStorage(AbstractStorage):
2525

2626
def __init__(
2727
self,
28-
redis_pool: "aioredis.Redis[bytes]",
28+
redis_pool: "aioredis.Redis",
2929
*,
3030
cookie_name: str = "AIOHTTP_SESSION",
3131
domain: Optional[str] = None,

demo/redis_storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ async def handler(request: web.Request) -> web.Response:
1818

1919
async def redis_pool(app: web.Application) -> AsyncIterator[None]:
2020
redis_address = "redis://127.0.0.1:6379"
21-
async with aioredis.from_url(redis_address) as redis:
21+
async with aioredis.from_url(redis_address) as redis: # type: ignore[no-untyped-call]
2222
storage = RedisStorage(redis)
2323
setup(app, storage)
2424
yield

requirements-dev.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,4 @@ mypy==1.7.0
99
pep257==0.7.0
1010
pre-commit==3.5.0
1111
sphinx==7.2.6
12-
types-redis==4.6.0.6
1312
typing-extensions==4.8.0

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ pytest-aiohttp==1.0.5
1010
pytest-cov==4.1.0
1111
pytest-mock==3.12.0
1212
pytest-sugar==0.9.7
13-
redis==5.0.0
13+
redis==5.0.1
1414
yarl==1.9.2

tests/conftest.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,14 @@ async def redis_server( # type: ignore[misc] # No docker types.
9292
delay = 0.1
9393
for _i in range(20): # pragma: no cover
9494
try:
95-
conn = aioredis.from_url(f"redis://{host}:{port}")
95+
conn = aioredis.from_url(f"redis://{host}:{port}") # type: ignore[no-untyped-call]
9696
await conn.set("foo", "bar")
9797
break
9898
except aioredis.ConnectionError:
9999
time.sleep(delay)
100100
delay *= 2
101101
finally:
102-
await conn.close()
102+
await conn.aclose()
103103
else: # pragma: no cover
104104
pytest.fail("Cannot start redis server")
105105

@@ -117,14 +117,14 @@ def redis_url(redis_server: _ContainerInfo) -> str: # type: ignore[misc]
117117
@pytest.fixture
118118
async def redis(
119119
redis_url: str,
120-
) -> AsyncIterator[aioredis.Redis[bytes]]:
121-
async def start(pool: aioredis.ConnectionPool) -> aioredis.Redis[bytes]:
120+
) -> AsyncIterator[aioredis.Redis]:
121+
async def start(pool: aioredis.ConnectionPool) -> aioredis.Redis:
122122
return aioredis.Redis(connection_pool=pool)
123123

124124
pool = aioredis.ConnectionPool.from_url(redis_url)
125125
redis = await start(pool)
126126
yield redis
127-
await redis.close()
127+
await redis.aclose()
128128
await pool.disconnect()
129129

130130

tests/test_redis_storage.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
def create_app(
2323
handler: Handler,
24-
redis: aioredis.Redis[bytes],
24+
redis: aioredis.Redis,
2525
max_age: Optional[int] = None,
2626
key_factory: Callable[[], str] = lambda: uuid.uuid4().hex,
2727
) -> web.Application:
@@ -34,7 +34,7 @@ def create_app(
3434

3535

3636
async def make_cookie(
37-
client: TestClient, redis: aioredis.Redis[bytes], data: Dict[Any, Any]
37+
client: TestClient, redis: aioredis.Redis, data: Dict[Any, Any]
3838
) -> None:
3939
session_data = {"session": data, "created": int(time.time())}
4040
value = json.dumps(session_data)
@@ -43,21 +43,21 @@ async def make_cookie(
4343
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": key})
4444

4545

46-
async def make_cookie_with_bad_value(client: TestClient, redis: aioredis.Redis[bytes]) -> None:
46+
async def make_cookie_with_bad_value(client: TestClient, redis: aioredis.Redis) -> None:
4747
key = uuid.uuid4().hex
4848
await redis.set("AIOHTTP_SESSION_" + key, "")
4949
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": key})
5050

5151

52-
async def load_cookie(client: TestClient, redis: aioredis.Redis[bytes]) -> Any:
52+
async def load_cookie(client: TestClient, redis: aioredis.Redis) -> Any:
5353
cookies = client.session.cookie_jar.filter_cookies(client.make_url("/"))
5454
key = cookies["AIOHTTP_SESSION"]
5555
value_bytes = await redis.get("AIOHTTP_SESSION_" + key.value)
5656
return None if value_bytes is None else json.loads(value_bytes)
5757

5858

5959
async def test_create_new_session(
60-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
60+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
6161
) -> None:
6262
async def handler(request: web.Request) -> web.StreamResponse:
6363
session = await get_session(request)
@@ -73,7 +73,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
7373

7474

7575
async def test_load_existing_session(
76-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
76+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
7777
) -> None:
7878
async def handler(request: web.Request) -> web.StreamResponse:
7979
session = await get_session(request)
@@ -90,7 +90,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
9090

9191

9292
async def test_load_bad_session(
93-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
93+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
9494
) -> None:
9595
async def handler(request: web.Request) -> web.StreamResponse:
9696
session = await get_session(request)
@@ -107,7 +107,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
107107

108108

109109
async def test_change_session(
110-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
110+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
111111
) -> None:
112112
async def handler(request: web.Request) -> web.StreamResponse:
113113
session = await get_session(request)
@@ -134,7 +134,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
134134

135135

136136
async def test_clear_cookie_on_session_invalidation(
137-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
137+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
138138
) -> None:
139139
async def handler(request: web.Request) -> web.StreamResponse:
140140
session = await get_session(request)
@@ -155,7 +155,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
155155

156156

157157
async def test_create_cookie_in_handler(
158-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
158+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
159159
) -> None:
160160
async def handler(request: web.Request) -> web.StreamResponse:
161161
session = await get_session(request)
@@ -182,7 +182,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
182182

183183

184184
async def test_set_ttl_on_session_saving(
185-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
185+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
186186
) -> None:
187187
async def handler(request: web.Request) -> web.StreamResponse:
188188
session = await get_session(request)
@@ -202,7 +202,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
202202

203203

204204
async def test_set_ttl_manually_set(
205-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
205+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
206206
) -> None:
207207
async def handler(request: web.Request) -> web.StreamResponse:
208208
session = await get_session(request)
@@ -223,7 +223,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
223223

224224

225225
async def test_create_new_session_if_key_doesnt_exists_in_redis(
226-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
226+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
227227
) -> None:
228228
async def handler(request: web.Request) -> web.StreamResponse:
229229
session = await get_session(request)
@@ -237,7 +237,7 @@ async def handler(request: web.Request) -> web.StreamResponse:
237237

238238

239239
async def test_create_storage_with_custom_key_factory(
240-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
240+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
241241
) -> None:
242242
async def handler(request: web.Request) -> web.StreamResponse:
243243
session = await get_session(request)
@@ -260,7 +260,7 @@ def key_factory() -> str:
260260

261261

262262
async def test_redis_session_fixation(
263-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
263+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
264264
) -> None:
265265
async def login(request: web.Request) -> web.StreamResponse:
266266
session = await get_session(request)
@@ -289,9 +289,9 @@ async def test_redis_from_create_pool(redis_url: str) -> None:
289289
async def handler(request: web.Request) -> web.Response: # type: ignore[empty-body]
290290
"""Dummy handler"""
291291

292-
redis = aioredis.from_url(redis_url)
292+
redis = aioredis.from_url(redis_url) # type: ignore[no-untyped-call]
293293
create_app(handler=handler, redis=redis)
294-
await redis.close()
294+
await redis.aclose()
295295

296296

297297
async def test_not_redis_provided_to_storage() -> None:
@@ -321,7 +321,7 @@ async def handler(request: web.Request) -> web.Response: # type: ignore[empty-b
321321

322322

323323
async def test_load_session_dont_load_expired_session(
324-
aiohttp_client: AiohttpClient, redis: aioredis.Redis[bytes]
324+
aiohttp_client: AiohttpClient, redis: aioredis.Redis
325325
) -> None:
326326
async def handler(request: web.Request) -> web.StreamResponse:
327327
session = await get_session(request)

0 commit comments

Comments
 (0)