Fix a bug: now web.Request.POST() processes duplicate field names

Author: asvetlov

aiohttp/web.py

@@ -358,7 +358,7 @@ def POST(self):
                     value = supported_tranfer_encoding[
                         transfer_encoding](value)
                 out.add(field.name, value)
-        self._post = MultiDict(out)
+        self._post = MultiDict(out.items(getall=True))
         return self._post
 
     # @asyncio.coroutine

tests/test_web_functional.py

@@ -5,6 +5,7 @@
 import unittest
 import tempfile
 from aiohttp import web, request, FormData
+from aiohttp.multidict import MultiDict
 
 
 class TestWebFunctional(unittest.TestCase):
@@ -267,3 +268,24 @@ def go(tmpdirname, filename):
                 fp.flush()
                 fp.seek(0)
                 self.loop.run_until_complete(go(tmpdirname, filename))
+
+    def test_post_form_with_duplicate_keys(self):
+
+        @asyncio.coroutine
+        def handler(request):
+            data = yield from request.POST()
+            lst = list(sorted(data.items(getall=True)))
+            self.assertEqual([('a', '1'), ('a', '2')], lst)
+            return web.Response(request, b'OK')
+
+        @asyncio.coroutine
+        def go():
+            _, _, url = yield from self.create_server('POST', '/', handler)
+            resp = yield from request('POST', url,
+                                      data=MultiDict([('a', 1), ('a', 2)]),
+                                      loop=self.loop)
+            self.assertEqual(200, resp.status)
+            txt = yield from resp.text()
+            self.assertEqual('OK', txt)
+
+        self.loop.run_until_complete(go())