Skip to content

Commit 0d44b6a

Browse files
Revert incorrect typing changes (#10222)
1 parent c67fd8f commit 0d44b6a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/workflows/ci-cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
- name: Setup Python
5050
uses: actions/setup-python@v5
5151
with:
52-
python-version: 3.13
52+
python-version: 3.11
5353
- name: Cache PyPI
5454
uses: actions/[email protected]
5555
with:

.mypy.ini

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ disallow_untyped_calls = True
1111
disallow_untyped_decorators = True
1212
disallow_untyped_defs = True
1313
# TODO(PY312): explicit-override
14-
enable_error_code = ignore-without-code, possibly-undefined, redundant-expr, redundant-self, truthy-bool, truthy-iterable, unused-awaitable
14+
enable_error_code = deprecated, ignore-without-code, possibly-undefined, redundant-expr, redundant-self, truthy-bool, truthy-iterable, unused-awaitable
1515
extra_checks = True
16+
follow_untyped_imports = True
1617
implicit_reexport = False
1718
no_implicit_optional = True
1819
pretty = True

aiohttp/http_parser.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,6 @@ def feed_data(
670670
) -> Tuple[List[Tuple[RawResponseMessage, StreamReader]], bool, bytes]:
671671
if SEP is None:
672672
SEP = b"\r\n" if DEBUG else b"\n"
673-
assert SEP is not None
674673
return super().feed_data(data, SEP, *args, **kwargs)
675674

676675
def parse_message(self, lines: List[bytes]) -> RawResponseMessage:

aiohttp/web_protocol.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,13 +583,13 @@ async def start(self) -> None:
583583
else:
584584
task = loop.create_task(coro)
585585
try:
586-
resp, reset = await task # type: ignore[possibly-undefined]
586+
resp, reset = await task
587587
except ConnectionError:
588588
self.log_debug("Ignored premature client disconnection")
589589
break
590590

591591
# Drop the processed task from asyncio.Task.all_tasks() early
592-
del task # type: ignore[possibly-undefined]
592+
del task
593593
# https://github.com/python/mypy/issues/14309
594594
if reset: # type: ignore[possibly-undefined]
595595
self.log_debug("Ignored premature client disconnection 2")

0 commit comments

Comments
 (0)