Skip to content

Commit 12ce811

Browse files
[PR #10981/2617ab23 backport][3.12] Fix flakey test_client_middleware_retry_reuses_connection test (#10986)
1 parent b21ae98 commit 12ce811

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

tests/test_client_middleware.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -863,8 +863,13 @@ async def test_client_middleware_retry_reuses_connection(
863863
aiohttp_server: AiohttpServer,
864864
) -> None:
865865
"""Test that connections are reused when middleware performs retries."""
866+
request_count = 0
866867

867868
async def handler(request: web.Request) -> web.Response:
869+
nonlocal request_count
870+
request_count += 1
871+
if request_count == 1:
872+
return web.Response(status=400) # First request returns 400 with no body
868873
return web.Response(text="OK")
869874

870875
class TrackingConnector(TCPConnector):
@@ -891,7 +896,7 @@ async def __call__(
891896
while True:
892897
self.attempt_count += 1
893898
response = await handler(request)
894-
if retry_count == 0:
899+
if response.status == 400 and retry_count == 0:
895900
retry_count += 1
896901
continue
897902
return response

0 commit comments

Comments
 (0)