Skip to content

Commit 2648c48

Browse files
committed
Extract configuration checks to module level
1 parent cc75414 commit 2648c48

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

aiohttp/connector.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,10 @@ def _create_connection(self, req, *args, **kwargs):
212212
raise NotImplementedError()
213213

214214

215+
_SSL_OP_NO_COMPRESSION = getattr(ssl, "OP_NO_COMPRESSION", 0)
216+
_SSH_HAS_CREATE_DEFAULT_CONTEXT = hasattr(ssl, 'create_default_context')
217+
218+
215219
class TCPConnector(BaseConnector):
216220
"""TCP connector.
217221
@@ -254,17 +258,17 @@ def ssl_context(self):
254258
sslcontext = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
255259
sslcontext.options |= ssl.OP_NO_SSLv2
256260
sslcontext.options |= ssl.OP_NO_SSLv3
257-
sslcontext.options |= getattr(ssl, "OP_NO_COMPRESSION", 0)
261+
sslcontext.options |= _SSL_OP_NO_COMPRESSION
258262
sslcontext.set_default_verify_paths()
259-
elif hasattr(ssl, 'create_default_context'):
263+
elif _SSH_HAS_CREATE_DEFAULT_CONTEXT:
260264
# Python 3.4+
261265
sslcontext = ssl.create_default_context()
262266
else: # pragma: no cover
263267
# Fallback for Python 3.3.
264268
sslcontext = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
265269
sslcontext.options |= ssl.OP_NO_SSLv2
266270
sslcontext.options |= ssl.OP_NO_SSLv3
267-
sslcontext.options |= getattr(ssl, "OP_NO_COMPRESSION", 0)
271+
sslcontext.options |= _SSL_OP_NO_COMPRESSION
268272
sslcontext.set_default_verify_paths()
269273
sslcontext.verify_mode = ssl.CERT_REQUIRED
270274
self._ssl_context = sslcontext

0 commit comments

Comments
 (0)