Skip to content

Commit 6ccd3d5

Browse files
[PR #10956/5dcb36a4 backport][3.12] Fix some missing connector closes in tests (#10957)
Co-authored-by: J. Nick Koston <[email protected]>
1 parent b5a061b commit 6ccd3d5

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

tests/test_client_middleware.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,8 @@ async def blocking_middleware(
793793
# Check that no connections were leaked
794794
assert len(connector._conns) == 0
795795

796+
await connector.close()
797+
796798

797799
async def test_client_middleware_blocks_connection_without_dns_lookup(
798800
aiohttp_server: AiohttpServer,

tests/test_proxy_functional.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,7 @@ async def test_proxy_http_acquired_cleanup(proxy_test_server, loop) -> None:
418418
assert 0 == len(conn._acquired)
419419

420420
await sess.close()
421+
await conn.close()
421422

422423

423424
@pytest.mark.skip("we need to reconsider how we test this")
@@ -439,6 +440,7 @@ async def request():
439440
assert 0 == len(conn._acquired)
440441

441442
await sess.close()
443+
await conn.close()
442444

443445

444446
@pytest.mark.skip("we need to reconsider how we test this")
@@ -470,6 +472,7 @@ async def request(pid):
470472
assert {resp.status for resp in responses} == {200}
471473

472474
await sess.close()
475+
await conn.close()
473476

474477

475478
@pytest.mark.xfail

tests/test_web_sendfile_functional.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,7 @@ async def test_static_file_ssl(
614614

615615
await resp.release()
616616
await client.close()
617+
await conn.close()
617618

618619

619620
async def test_static_file_directory_traversal_attack(aiohttp_client) -> None:

0 commit comments

Comments
 (0)